If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Move LD to python configure

RESOLVED FIXED in Firefox 53

Status

()

Core
Build Config
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

(Blocks: 1 bug)

unspecified
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(5 attachments)

Comment hidden (empty)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 6

10 months ago
mozreview-review
Comment on attachment 8814016 [details]
Bug 1317504 - Warn that LD is not used by the build system.

https://reviewboard.mozilla.org/r/95310/#review96518
Attachment #8814016 - Flags: review?(cmanchester) → review+

Comment 7

10 months ago
mozreview-review
Comment on attachment 8814017 [details]
Bug 1317504 - Remove unused non-GCC/clang flags settings.

https://reviewboard.mozilla.org/r/95312/#review96522
Attachment #8814017 - Flags: review?(cmanchester) → review+

Comment 8

10 months ago
mozreview-review
Comment on attachment 8814018 [details]
Bug 1317504 - Remove the GNU_LD variable, nothing uses it.

https://reviewboard.mozilla.org/r/95314/#review96532
Attachment #8814018 - Flags: review?(cmanchester) → review+

Comment 9

10 months ago
mozreview-review
Comment on attachment 8814019 [details]
Bug 1317504 - Make MSVC builds use the LINK variable instead of LD.

https://reviewboard.mozilla.org/r/95316/#review96534
Attachment #8814019 - Flags: review?(cmanchester) → review+

Comment 10

10 months ago
mozreview-review
Comment on attachment 8814020 [details]
Bug 1317504 - Don't try to set LD from old-configure.

https://reviewboard.mozilla.org/r/95318/#review96536
Attachment #8814020 - Flags: review?(cmanchester) → review+

Comment 11

10 months ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/cffe1cd111f6
Warn that LD is not used by the build system. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/677f47fec9e7
Remove unused non-GCC/clang flags settings. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/fd007caf51df
Remove the GNU_LD variable, nothing uses it. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/6353e704bf2c
Make MSVC builds use the LINK variable instead of LD. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/8c1409a443ee
Don't try to set LD from old-configure. r=chmanchester

Comment 12

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/cffe1cd111f6
https://hg.mozilla.org/mozilla-central/rev/677f47fec9e7
https://hg.mozilla.org/mozilla-central/rev/fd007caf51df
https://hg.mozilla.org/mozilla-central/rev/6353e704bf2c
https://hg.mozilla.org/mozilla-central/rev/8c1409a443ee
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.