1317000 - Display permissions prompt for webextensions installed locally from about:addons

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Andrew Swan [:aswan]]

The specified flow for local installs is similar to that from web sites, this bug covers implementing that flow for installation from about:addons (either by choosing "Install Add-on from File..." from the gear menu or by dragging and dropping an xpi file onto about:addons)

Comment 1

[emanuela [ux]]

Attachment: permissions from about:addons

UI

Comment 2

[Andrew Swan [:aswan]]

Attachment: bug 1317000 Test for permission prompts on local file installs

Review commit: https://reviewboard.mozilla.org/r/109398/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/109398/

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8833162 [details]
bug 1317000 Test for permission prompts on local file installs

https://reviewboard.mozilla.org/r/109398/#review110694

Mostly there but there are a few things that I think can be cleaned up here.

::: browser/base/content/test/general/browser_extension_permissions.js:70
(Diff revision 1)
> +// that resolves when the page is loaded.
> +function load(url) {
> +  let contentWin = gBrowser.selectedTab.linkedBrowser.contentWindow;
> +  let promise = new Promise(resolve => {
> +    gBrowser.addEventListener("DOMContentLoaded", resolve, {once: true});
> +  });

Please use BrowserTestUtils.browserLoaded

::: browser/base/content/test/general/browser_extension_permissions.js:71
(Diff revision 1)
> +function load(url) {
> +  let contentWin = gBrowser.selectedTab.linkedBrowser.contentWindow;
> +  let promise = new Promise(resolve => {
> +    gBrowser.addEventListener("DOMContentLoaded", resolve, {once: true});
> +  });
> +  contentWin.location.href = INSTALL_PAGE;

Please use gBrowser.selectedBrowser.loadURI

::: browser/base/content/test/general/browser_extension_permissions.js:115
(Diff revision 1)
> +      };
> +      Services.obs.addObserver(listener, "EM-loaded", false);
> +    });
> +
> +    let contentWin = gBrowser.selectedTab.linkedBrowser.contentWindow;
> +    contentWin.location.href = "about:addons";

Please use gBrowser.selectedBrowser.loadURI, it guarantees you won't be using a CPOW.

Alternativly can you just use BrowserOpenAddonsMgr which handles waiting for the load to complete already and lets you choose the initial view?

Comment 4

[Andrew Swan [:aswan]]

Comment on attachment 8833162 [details]
bug 1317000 Test for permission prompts on local file installs

https://reviewboard.mozilla.org/r/109398/#review110694

> Please use gBrowser.selectedBrowser.loadURI, it guarantees you won't be using a CPOW.
> 
> Alternativly can you just use BrowserOpenAddonsMgr which handles waiting for the load to complete already and lets you choose the initial view?

wow, how did i get this far without ever coming across BrowserOpenAddonsMgr before?

Comment 5

[Andrew Swan [:aswan]]

Comment on attachment 8833162 [details]
bug 1317000 Test for permission prompts on local file installs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/109398/diff/1-2/

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 8833162 [details]
bug 1317000 Test for permission prompts on local file installs

https://reviewboard.mozilla.org/r/109398/#review110750

Well that became simpler!

Comment 7

[Andrew Swan [:aswan]]

Comment on attachment 8833162 [details]
bug 1317000 Test for permission prompts on local file installs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/109398/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b46165a0e3d6
Test for permission prompts on local file installs r=mossop

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b46165a0e3d6

Comment 10

[Vasilica Tamas, QA [:vtamas]]

Verified fixed on Firefox 54.0a1 (2017-02-19) under Windows 10 64-bit and Ubuntu 16.04 32-bit.
Permissions doorhanger is successfully displayed while installing locally via about:addons: https://www.screencast.com/t/5ivxUhr7n