1317096 - Bookmarks view no longer correctly shows desktop bookmarks

Status: VERIFIED FIXED

(Firefox for iOS :: Sync, defect, P1)

Description

[Richard Newman [:rnewman]]

* Install Fx 6 beta.
* Sign in to Sync.
* Sync bookmarks.

You'll notice that all of your desktop bookmarks made it into the DB: if you type part of the URL or title, you'll see them in the suggestions, complete with star. That means they're in the buffer.

You won't, however, see them in the bookmarks list.

On my iPad, I see "Desktop Bookmarks" containing one folder, "Mobile Bookmarks", which includes my server-side mobile bookmarks.

On my iPhone, I see just the empty state.

I think I've been seeing this on iPad since before Bug 1278262, so I haven't had any luck using `git log` to find potential culprits.

Comment 1

[Stephan Leroux [:sleroux]]

I haven't been able to reproduce this on the simulator/device. Is there any additional steps or does it happen randomly?

Comment 2

[Richard Newman [:rnewman]]

It might be related to my bookmark data. Want me to investigate?

Comment 3

[Stephan Leroux [:sleroux]]

Sure if you're able to repro on your device!

Comment 4

[Richard Newman [:rnewman]]

2016-11-17 09:28:57.493 [Debug] [SQLiteBookmarksModel.swift:842] modelFactory > Using local+mirror bookmark factory.
2016-11-17 09:28:57.494 [Debug] [SQLiteBookmarksModel.swift:120] modelForRoot() > Getting model for root.
2016-11-17 09:28:57.501 [Debug] [SQLiteBookmarksModel.swift:208] onlyMobile() > No desktop bookmarks. Only showing mobile.

Well, that'll be why.

Comment 5

[Richard Newman [:rnewman]]

The reason is that while the buffer contains plenty of bookmarks, it doesn't contain the structure for the four roots:

sqlite> SELECT COUNT(*) FROM bookmarksBuffer;
COUNT(*)
----------
2316
sqlite> SELECT COUNT(*) FROM bookmarksBufferStructure;
COUNT(*)
----------
1789
sqlite> SELECT EXISTS(SELECT 1 FROM bookmarksBufferStructure WHERE parent IN ('menu________', 'toolbar_____', 'unfiled_____', 'mobile______'));
EXISTS(SELECT 1 FROM bookmarksBufferStructure WHERE parent IN ('menu________', 'toolbar_____', 'unfiled_____', 'mobile______'))
---------------------------------------------------------------------------------------------
0

so hasOnlyUnmergedRemoteBookmarks returns 'no', and we use local+mirror.

Comment 6

[Richard Newman [:rnewman]]

And here's the root cause:

2016-11-17 10:18:30.531 [Warning] [BookmarkPayload.swift:500] isValid() > Not the places root and missing parent name.
2016-11-17 10:18:30.543 [Warning] [Record.swift:59] fromEnvelope(_:payloadFactory:) > Invalid payload {
  "title" : "Bookmarks Toolbar",
  "description" : "Add bookmarks to this folder to see them displayed on the Bookmarks Toolbar",
  "id" : "toolbar",
  "children" : [
    "uZJ-SgK5kgE2",
    "8RPb1N8Ozaf0",
    "ZFI_J-9ihosn",
    "B8WxDqcMMQqf",
    "nE_IBTKMGA1c",
    "5ZO9vzgNn6I8",
    "MOi2WFUAYBQJ",
    "slf34ON7SOO-",
    "5nx3XFeVbGH3",
    "loX7JRkZ19Xx",
    "63_yHk-4W3lY",
    "vq-xRNJKJ_21",
    "BZPgOt-0LSjt",
    "H4VaXmepqAK2"
  ],
  "parentid" : "places",
  "type" : "folder"
}.

Comment 7

[Richard Newman [:rnewman]]

Attachment: Workaround.

Comment 8

[Stephan Leroux [:sleroux]]

Comment on attachment 8811850 [details] [review]
Workaround.

LGTM!

Comment 9

[Richard Newman [:rnewman]]

master: 79c6e2a 

Steph, could you uplift as you're cutting new betas?

Comment 10

[Stephan Leroux [:sleroux]]

Yup - I'm just about to release b4 but I can make a new one tomorrow.

Comment 11

[Stephan Leroux [:sleroux]]

v6.x d787fc9

Comment 12

[Simon Basca [:SimonB]]

Verifying as fix on 6.0b5. The desktop bookmarks are correctly displayed.