1317179 - Stylo: Use XPCOM string bindings instead of Gecko_Utf8SliceToString

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect, P3)

Description

[Brian Birtles (:birtles)]

In bug 1302949 I introduced some fairly clumsy string handling while we were waiting for bug 1294742 (actually bug 1295762) to land. I haven't looked into those bindings at all, but now that they've landed I wonder if we can:

* Use them in Servo_DeclarationBlock_SerializeOneValue[1]
* Drop Gecko_Utf8SliceToString[2]

[1] https://dxr.mozilla.org/servo/rev/38e97d26c6e812bb2a8ba3f46707625ee733e56e/ports/geckolib/glue.rs#503
[2] http://searchfox.org/mozilla-central/rev/4b6cab91f93c73ae591dafaea40fd5704b41810e/layout/style/ServoBindings.h#147

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1317179 - Use nsAString as the parameter type and drop Gecko_Utf8SliceToString.

Review commit: https://reviewboard.mozilla.org/r/95052/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95052/

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1317179 - [Servo] Use XPCOM string bindings instead of Gecko_Utf8SliceToString.

Review commit: https://reviewboard.mozilla.org/r/95054/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95054/

Comment 3

[Manish Goregaokar [:manishearth]]

Comment on attachment 8813619 [details]
Bug 1317179 - [Servo] Use XPCOM string bindings instead of Gecko_Utf8SliceToString.

https://reviewboard.mozilla.org/r/95054/#review95280

::: servo/ports/geckolib/glue.rs:493
(Diff revision 1)
>      let property = get_property_name_from_atom(property, is_custom);
>      let mut string = String::new();
>      let rv = declarations.read().single_value_to_css(&property, &mut string);
>      debug_assert!(rv.is_ok());
>  
> -    // FIXME: Once we have nsString bindings for Servo (bug 1294742), we should be able to drop
> +    write!(unsafe { buffer.as_mut().unwrap() }, "{}", string).expect("Failed to copy string");

`&mut *` buffer should work here.

Comment 4

[Manish Goregaokar [:manishearth]]

Comment on attachment 8813618 [details]
Bug 1317179 - Use nsAString as the parameter type and drop Gecko_Utf8SliceToString.

https://reviewboard.mozilla.org/r/95052/#review95282

Comment 5

[Boris Chiou [:boris]]

Comment on attachment 8813619 [details]
Bug 1317179 - [Servo] Use XPCOM string bindings instead of Gecko_Utf8SliceToString.

https://reviewboard.mozilla.org/r/95054/#review95280

> `&mut *` buffer should work here.

Thanks, I will replace my code with "unsafe { &mut * buffer }".

Comment 6

[Boris Chiou [:boris]]

I will create a PR and land the gecko-side change after bug 1317178 is merged to m-c.

Comment 7

[Boris Chiou [:boris]]

Comment on attachment 8813618 [details]
Bug 1317179 - Use nsAString as the parameter type and drop Gecko_Utf8SliceToString.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/95052/diff/1-2/

Comment 8

[Boris Chiou [:boris]]

Comment on attachment 8813619 [details]
Bug 1317179 - [Servo] Use XPCOM string bindings instead of Gecko_Utf8SliceToString.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/95054/diff/1-2/

Comment 9

[Boris Chiou [:boris]]

Attachment: Servo PR, #14404

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53d1dbd5e905
Use nsAString as the parameter type and drop Gecko_Utf8SliceToString. r=manishearth

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/53d1dbd5e905