1317182 - Fix button text alignment of Preference button and Remove button in about:preferences#containers

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[magicp]

Attachment: Fix button text alignment of Preference button and Remove button.png

Steps to Reproduce:
1. Start Nightly
2. Go to about:preferences#containers
3. Conform button text alignment of Preference button and Remove button

Actual Results:
Button text alignment is in the left side.
(* In the attached image, button width is changed for easy to see) 

Expected Results:
Button text alignment is center.

Comment 1

[Kamil Jozwiak [:kjozwiak]]

It looks like this only affects Win/Ubuntu. The text within the buttons seems correctly aligned under macOS 10.12.2.

Comment 2

[magicp]

(In reply to Kamil Jozwiak [:kjozwiak] from comment #1)
> It looks like this only affects Win/Ubuntu. The text within the buttons
> seems correctly aligned under macOS 10.12.2.

You are wrong. It affects on macOS 10.12.2.

Comment 3

[Kamil Jozwiak [:kjozwiak]]

Attachment: editedPadding.png

> You are wrong. It affects on macOS 10.12.2.

Hmmm, I can't seem to reproduce it on macOS :/ I've even changed the padding [1] and it seems like the text is correctly being aligned. With Ubuntu/Win, you can tell off that bat that the "Remove" text isn't being correctly aligned but in macOS, it seems like it's correctly being aligned [2].

CC'ing Jonathan as well as he's the one that usually works on container UI bugs.

[1] editedPadding.png
[2] default.png

Comment 4

[Kamil Jozwiak [:kjozwiak]]

Attachment: default.png

Comment 5

[magicp]

(In reply to Kamil Jozwiak [:kjozwiak] from comment #4)
> Created attachment 8819918 [details]
> default.png

I understand, you should edit button width. (not padding)
For example, you can see different padding-left/right of the remove button in default.png.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This gets fixed by bug 1315458.

Comment 7

[magicp]

I confirmed this bug was fixed on 53. Thanks!