1317198 - Crash in java.lang.NullPointerException: Attempt to invoke virtual method ''int org.mozilla.gecko.Tab.getId()'' on a null object reference at org.mozilla.gecko.GeckoApp.onPause(GeckoApp.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

This bug was filed from the Socorro interface and is 
report bp-ddf12a38-15bc-4ecb-92b0-17c112161114.
=============================================================

Comment 1

[Andrzej Hunt :ahunt]

This seems to be caused by Bug 1305439, see the bottom of:
https://hg.mozilla.org/mozilla-central/rev/fe3fe09d24c8

Comment 2

[Dylan Roeh (:droeh) (he/him)]

Attachment: Null-check the Tab

This just checks if the tab is null before attempting to update the lastSelectedTabId; I didn't think it was possible to hit GeckoApp.onPause() with Tabs.mSelectedTab still being null, but apparently I was mistaken.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8810418 [details] [diff] [review]
Null-check the Tab

Review of attachment 8810418 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/java/org/mozilla/gecko/GeckoApp.java
@@ +2155,5 @@
>          }
>  
> +        final Tab selectedTab = Tabs.getInstance().getSelectedTab();
> +        if (selectedTab != null) {
> +            lastSelectedTabId = Tabs.getInstance().getSelectedTab().getId();

This probably should use 'selectedTab' instead of requesting it again?

Comment 5

[Dylan Roeh (:droeh) (he/him)]

Attachment: Null-check the Tab v1.1

Yup, meant to use selectedTab there. The dangers of copy and paste :)

Carrying over the r+.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f8126c38179
Check if a tab is null before trying to get its id in GeckoApp.onPause() r=sebastian

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0f8126c38179

Comment 8

[Andrzej Hunt :ahunt]

1 instance of this crash has been spotted in aurora (52) too, we should probably uplift it?

Comment 9

[Marcia Knous [:marcia]]

[Tracking Requested - why for this release]:

Adjusting flags - I think in Comment 8 Andrzej wanted to track for 52, not 53 where it is resolved fixed.

Comment 10

[Dylan Roeh (:droeh) (he/him)]

Comment on attachment 8811302 [details] [diff] [review]
Null-check the Tab v1.1

Approval Request Comment
[Feature/regressing bug #]:1305439
[User impact if declined]:Potential for crashes
[Describe test coverage new/current, TreeHerder]:https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=0f8126c38179a6475b550ed97f0dfac42c4899b6
[Risks and why]: Low-risk, we just check if the selected tab is null and fall back to the old behavior if it is.
[String/UUID change made/needed]:

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 8811302 [details] [diff] [review]
Null-check the Tab v1.1

fix possible fennec crash, take for aurora52

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/35fdeedf2867