Closed Bug 1317359 Opened 4 years ago Closed 4 years ago

Android beta 51 builds fail with "Must specify --with-adjust-sdk-keyfile when MOZ_INSTALL_TRACKING is defined!"

Categories

(Firefox Build System :: General, defect)

defect
Not set
blocker

Tracking

(firefox51 fixed, firefox52 fixed, firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox51 --- fixed
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: cbook, Unassigned)

References

()

Details

Attachments

(2 files)

No idea if this is a real problem or intermittent but https://treeherder.mozilla.org/logviewer.html#?job_id=1916768&repo=mozilla-beta fails now 3 times in a row.
Callek, can you take a look if this is merge day related, thanks!
Flags: needinfo?(bugspam.Callek)
This shouldn't be using hg unbundle (well I'm not sure why, but we should just be using robustcheckout instead)  Its also not fatal in terms of hg ubundling due to the "falling back to clone"

 Trying to use bundle https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/bundles/mozilla-beta.hg
 command: START
 command: hg unbundle --traceback https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/bundles/mozilla-beta.hg
 command: cwd: /builds/hg-shared/releases/mozilla-beta
 command: env: {'HGPLAIN': '1'}
 Hit exception running hg:
 Traceback (most recent call last):
   File "/builds/slave/m-beta-and-api-15-000000000000/tools/buildfarm/utils/../../lib/python/util/hg.py", line 99, in get_hg_output
     return get_output(['hg'] + cmd, timeout=timeout, env=env, **kwargs)
   File "/builds/slave/m-beta-and-api-15-000000000000/tools/buildfarm/utils/../../lib/python/util/commands.py", line 207, in get_output
     raise error
 CalledProcessError: Command '['hg', 'unbundle', '--traceback', 'https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/bundles/mozilla-beta.hg']' returned non-zero exit status 255
Using bundles failed; falling back to clone
Flags: needinfo?(bugspam.Callek)
Real error is later on with ""DEBUG: configure: error: Must specify --with-adjust-sdk-keyfile when MOZ_INSTALL_TRACKING is defined!""
:glandium, you were the one to move these keyfiles to python configure, can you investigate this beta-only fallout?
Depends on: 1294585
Flags: needinfo?(mh+mozilla)
Summary: Android 4.0 API15+ opt fails to checkout after merge day → Android beta 51 builds fail with "Must specify --with-adjust-sdk-keyfile when MOZ_INSTALL_TRACKING is defined!"
Comment on attachment 8810611 [details]
Bug 1317359 - Move add_old_configure_* functions to util.configure.

https://reviewboard.mozilla.org/r/92902/#review92858
Attachment #8810611 - Flags: review?(cmanchester) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/c403ebdab6b8
Propagate MOZ_ADJUST_SDK_KEY to old-configure. r=chmanchester
Severity: normal → blocker
That's what you get for not amending a commit before pushing.
Flags: needinfo?(mh+mozilla)
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/6d6366a2842e
Propagate MOZ_ADJUST_SDK_KEY to old-configure. r=chmanchester
Attachment #8810611 - Flags: review+ → review?(cmanchester)
Component: General Automation → Build Config
Product: Release Engineering → Core
QA Contact: catlee
Comment on attachment 8810611 [details]
Bug 1317359 - Move add_old_configure_* functions to util.configure.

https://reviewboard.mozilla.org/r/92902/#review93280
Attachment #8810611 - Flags: review?(cmanchester) → review+
Comment on attachment 8810724 [details]
Bug 1317359 - Propagate MOZ_ADJUST_SDK_KEY to old-configure.

https://reviewboard.mozilla.org/r/93032/#review93282
Attachment #8810724 - Flags: review?(cmanchester) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/387015ba9c74
Move add_old_configure_* functions to util.configure. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/40935ab99b85
Propagate MOZ_ADJUST_SDK_KEY to old-configure. r=chmanchester
Still need to uplift to aurora
Comment on attachment 8810724 [details]
Bug 1317359 - Propagate MOZ_ADJUST_SDK_KEY to old-configure.

(Note this is post-facto for beta)

Approval Request Comment
[Feature/regressing bug #]: Regression from bug 1294585 only affecting android beta
[User impact if declined]: Can't build beta (IOW, 52 will fail to build when it reaches beta ; 51 failed to build when it reached beta).
[Describe test coverage new/current, TreeHerder]: The bug breaks running configure, so configure passing, and existing unit tests not failing is how we know this fixes the issue.
[Risks and why]: Low, cf. above.
[String/UUID change made/needed]: None

BTW: this should have been caught by {central,aurora}-as-beta pushes to try, haven't there been any?
Attachment #8810724 - Flags: approval-mozilla-beta?
Attachment #8810724 - Flags: approval-mozilla-aurora?
Note I'm only flagging one patch, for convenience, but both patches are required.
Comment on attachment 8810611 [details]
Bug 1317359 - Move add_old_configure_* functions to util.configure.

fix fennec build on beta, uplift to 51 and 52
Attachment #8810611 - Flags: approval-mozilla-beta+
Attachment #8810611 - Flags: approval-mozilla-aurora+
Comment on attachment 8810724 [details]
Bug 1317359 - Propagate MOZ_ADJUST_SDK_KEY to old-configure.

fix fennec build on beta, uplift to 51 and 52 (this one already landed on beta)
Attachment #8810724 - Flags: approval-mozilla-beta?
Attachment #8810724 - Flags: approval-mozilla-beta+
Attachment #8810724 - Flags: approval-mozilla-aurora?
Attachment #8810724 - Flags: approval-mozilla-aurora+
Comment on attachment 8810611 [details]
Bug 1317359 - Move add_old_configure_* functions to util.configure.

I pushed this to beta to fix the bustage from only 1 part landing:
https://hg.mozilla.org/releases/mozilla-beta/rev/749a8d32b74eae516b9427f28aad4ec1c11e0a54
https://hg.mozilla.org/mozilla-central/rev/387015ba9c74
https://hg.mozilla.org/mozilla-central/rev/40935ab99b85
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
has problems to apply to beta

warning: conflicts while merging build/moz.configure/util.configure! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')
Flags: needinfo?(mh+mozilla)
It's already on beta, cf. comment 18 and comment 24
Flags: needinfo?(mh+mozilla)
(In reply to Mike Hommey [:glandium] from comment #28)
> It's already on beta, cf. comment 18 and comment 24

oh right setting flags then
See Also: → 1372541
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.