1372541 - Fennec 55.0b1 fails on l10n repacks for missing `with-adjust-sdk-keyfile` parameter

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Mihai Tabara [:mtabara]⌚️GMT]

[task 2017-06-13T09:42:10.844248Z] 09:42:10     INFO -  checking for jarsigner... /home/worker/workspace/build/src/java_home/bin/jarsigner
[task 2017-06-13T09:42:10.844808Z] 09:42:10     INFO -  checking for keytool... /home/worker/workspace/build/src/java_home/bin/keytool
[task 2017-06-13T09:42:10.845371Z] 09:42:10     INFO -  checking for javac... /home/worker/workspace/build/src/java_home/bin/javac
[task 2017-06-13T09:42:10.952317Z] 09:42:10     INFO -  checking for javac version... 1.7.0_85
[task 2017-06-13T09:42:10.952858Z] 09:42:10     INFO -  ERROR: You must specify --with-adjust-sdk-keyfile=/path/to/keyfile when building with MOZ_INSTALL_TRACKING=1
[task 2017-06-13T09:42:10.977222Z] 09:42:10     INFO -  *** Fix above errors and then restart with\
[task 2017-06-13T09:42:10.977477Z] 09:42:10     INFO -                 "make -f client.mk build"
[task 2017-06-13T09:42:10.977622Z] 09:42:10     INFO -  client.mk:379: recipe for target 'configure' failed
[task 2017-06-13T09:42:10.977794Z] 09:42:10     INFO -  make: *** [configure] Error 1
[task 2017-06-13T09:42:10.978028Z] 09:42:10    ERROR - Return code: 2
[task 2017-06-13T09:42:10.978245Z] 09:42:10    FATAL - Configure failed!
[task 2017-06-13T09:42:10.978478Z] 09:42:10    FATAL - Running post_fatal callback...
[task 2017-06-13T09:42:10.978674Z] 09:42:10    FATAL - Exiting -1
[task 2017-06-13T09:42:10.978907Z] 09:42:10     INFO - [mozharness: 2017-06-13 09:42:10.978826Z] Finished setup step (failed)
[task 2017-06-13T09:42:10.979030Z] 09:42:10     INFO - Running post-run listener: copy_logs_to_upload_dir
[task 2017-06-13T09:42:10.979143Z] 09:42:10     INFO - Copying logs to upload dir...
[task 2017-06-13T09:42:10.979384Z] 09:42:10     INFO - mkdir: /home/worker/workspace/build/upload/logs


Task sample at [1]. Full log at [2].

[1]: https://tools.taskcluster.net/task-group-inspector/#/uR6dZ6pWT7OjUcEp1qbIzA/eohUBOQIRRWb_Aa-bpp3_Q?_k=t2uec4
[2]: https://public-artifacts.taskcluster.net/eohUBOQIRRWb_Aa-bpp3_Q/0/public/logs/live_backing.log

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

Unclear to me yet if this is a fallback from https://hg.mozilla.org/releases/mozilla-beta/rev/2191d7f87e2e or some of the mozconfigs that got merged. Error comes from https://dxr.mozilla.org/mozilla-central/source/mobile/android/moz.configure#140 as far as I can tell. Still debugging.

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

Callek: I couldn't find too many config differences between a good 54.0bXXX beta and a 55.0b1. 
Not sure where to dig further. 
@Callek: do you have any hints/suggestions?
Thanks!

Comment 3

[Justin Wood (:Callek)]

Attachment: Bug 1372541 - explicitly disable MOZ_INSTALL_TRACKING for l10n, to avoid failures from missing sdk keys, which will all be inherited from en-US anyway.

Review commit: https://reviewboard.mozilla.org/r/148484/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148484/

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 8877146 [details]
Bug 1372541 - explicitly disable MOZ_INSTALL_TRACKING for l10n, to avoid failures from missing sdk keys, which will all be inherited from en-US anyway.

https://reviewboard.mozilla.org/r/148484/#review152926

Comment 5

[Justin Wood (:Callek)]

https://hg.mozilla.org/releases/mozilla-beta/rev/7421b6df2ce2f798289ea29662f08d23a0c0d18d

I'm holding off on autolanding to avoid this bug becomming useless from mozreview's landing process. Incase a followup is needed.

Self-ni to ensure I actually do land it though

Comment 6

[Mihai Tabara [:mtabara]⌚️GMT]

The fix worked for Fennec 55.0b1-build2. Green graph https://tools.taskcluster.net/task-group-inspector/#/T_ZcoEWkTHqY0nW4Tru3Ew/
Assigning this to :Callek as he did the work.
Thank you!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4dd3e9b8f16c
explicitly disable MOZ_INSTALL_TRACKING for l10n, to avoid failures from missing sdk keys, which will all be inherited from en-US anyway. r=ted

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4dd3e9b8f16c