1317398 - Unhide ASan gtests on release branches if they ever have a reasonable failure percentage

Status: RESOLVED WONTFIX

(Tree Management Graveyard :: Visibility Requests, defect)

Comment 1

[Ryan VanderMeulen [:RyanVM]]

FWIW, the buildbot-based jobs had to run on a different instance from the other ASAN tests as well (Ubuntu ASAN VM large 12.04 x64 opt test gtest). Greg, can you help find an owner for this?

Comment 2

[Phil Ringnalda (:philor)]

If exclusions weren't such a pain to edit I would have included buildbot too, since it has failed 6 of the last 10 runs on mozilla-release (the last one where it's still running) from bug 1303927.

Comment 3

[Greg Arndt [:garndt]]

So it sounds like the ASAN gtests must run on a different instance type....do we know if that's the cause of the failures here for TaskCluster? Looping Joel in in case he has any idea as I do not know much about these tests.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

given that these are hidden on treeherder for all branches for both buildbot/taskcluster, we should question the value of having these around- adding :decoder, :mccr8, :chmanchester as they are interested parties

Comment 5

[Andrew McCreight [:mccr8]]

I'm not familiar with gtests, so I don't know how useful it is to run them in ASan.

Comment 6

[Nicholas Nethercote [inactive]]

gtests are C++ unit tests. Running them under ASan sounds like a reasonable and desirable thing to do.

Comment 7

[Phil Ringnalda (:philor)]

Don't you just love the magic of the passage of time? When treeherder decided to get rid of exclusions in favor of in-tree tiers, it apparently decided to just ignore the problem of dealing with this particular unworkable case, so now they are visible again, and although they pretty much suck on esr52 we're pretty much indifferent to unstarred suckage there, and on beta/release they aren't half bad.

Comment 8

[Ed Morley [:emorley]]

That isn't exactly correct.

It's still possible to hide the jobs if desired (see https://treeherder.readthedocs.io/common_tasks.html#hide-jobs-with-tiers). However for ESR branches if things are worthy of being hidden, then they really should be disabled (which is why when the transition to to tiers occurred, non trunk branches were only briefly scanned when constructing https://github.com/mozilla/treeherder/blob/0b31c14d308a7b856c31c292102993e02124a067/treeherder/etl/buildapi.py#L24-L52).