Closed Bug 1317569 Opened 3 years ago Closed 3 years ago

Unship d3dcompiler_43.dll

Categories

(Firefox Build System :: General, defect)

x86
Windows
defect
Not set

Tracking

(firefox52 wontfix, firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox52 --- wontfix
firefox53 --- fixed

People

(Reporter: emk, Unassigned)

References

Details

Attachments

(2 files)

We needed d3dcompiler_43.dll only for WinXP. It will reduce the installer size by 0.5MB to unship d3dcompiler_43.dll. As an added bonus, we will no longer depend on DirectX SDK (June 2010).
No longer blocks: xp-eol
Depends on: xp-eol
Comment on attachment 8810805 [details]
Bug 1317569 - Unship d3dcompiler_43.dll.

https://reviewboard.mozilla.org/r/93140/#review93308

This shouldn't happen before we _actually_ drop support for Windows XP.
Attachment #8810805 - Flags: review?(mh+mozilla)
Attachment #8810806 - Flags: review?(jmuizelaar)
Depends on: 1322646
No longer depends on: xp-eol
See Also: → 1322664
Re-requesting review because bug 1322646 has been fixed.
Comment on attachment 8810806 [details]
Bug 1317569 - Stop testing d3dcompiler_43.dll during EGL initialization.

https://reviewboard.mozilla.org/r/93142/#review100804
Attachment #8810806 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8810805 [details]
Bug 1317569 - Unship d3dcompiler_43.dll.

https://reviewboard.mozilla.org/r/93140/#review100954
Attachment #8810805 - Flags: review?(mh+mozilla) → review+
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/ace9b5fc8f65
Unship d3dcompiler_43.dll. r=glandium
https://hg.mozilla.org/integration/autoland/rev/6d89952994fb
Stop testing d3dcompiler_43.dll during EGL initialization. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/ace9b5fc8f65
https://hg.mozilla.org/mozilla-central/rev/6d89952994fb
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
our installer size got smaller thanks to these patches:
== Change summary for alert #4593 (as of December 22 2016 07:51 UTC) ==

Improvements:

  2%  installer size summary windows2012-32 opt       53222393.67 -> 52297712.5
  2%  installer size summary windowsxp opt            53285162.25 -> 52363130.5
  2%  installer size summary windows2012-32 pgo       54382640.58 -> 53461749.58
  1%  installer size summary windowsxp debug          66843409.08 -> 65919170.92
  1%  installer size summary windows2012-32 debug     66759350.17 -> 65834991.58

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=4593
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.