1322664 - Add entries to browser/installer/removed-files.in to facilitate 32bit -> 64bit Windows upgrades

Status: RESOLVED WONTFIX

(Release Engineering :: Release Requests, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

This is to figure out if we need to modify removed-files.in to smooth these architecture changing updates. There are two cases that might need handling:

* partial updates, eg I built a 49.0.2 win32 --> 50.0.2 win64 partial, and the manifest had these extra lines (compared to the win64 -> win64 case):
+add "qipcap64.dll"
+remove "wow_helper.exe"
+remove "breakpadinjector.dll"
+remove "D3DCompiler_43.dll"
** this should work fine as is, but need to check if this would have left anything else behind after the partial was applied

* complete updates may need the three remove instructions above. IIRC the updater will remove the files listed in the (already on disk) precomplete file, cleaning up the existing install before adding the new files in complete mar. So this could be a no-op too.

Testing of actual updates required. Leaving this in a RelEng component until we know what is needed.

Comment 1

[Robert Strong (they/them - no direct email)]

You shouldn't need to add any entries to removed-files.in and this bug should be wontfix

If you create a partial, the files in the x64 build will be compared to the files in the x86 build. This will automatically create remove instructions.

When the client gets the complete the precomplete file will the remove instructions.

Comment 2

[Robert Strong (they/them - no direct email)]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #1)
>...
> When the client gets the complete the precomplete file will the remove
> instructions.
When the client gets the complete the precomplete file will add the remove instructions.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Fantastic. This was just filed out of an (over) abundance of caution, and maybe should have been title 'test 32 -> 64bit updates to look for anything strange'.

Comment 4

[Chris Peterson [:cpeterson]]

WONTFIX as per Robert's comment 1. We will just need to verify that the generated remove instructions work correctly we test the upgrade.

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

How/where are we recording that we will do that check ?

Comment 6

[Chris Peterson [:cpeterson]]

(In reply to Nick Thomas [:nthomas] from comment #5)
> How/where are we recording that we will do that check ?

We will have a manual test plan for Softvision QA and we can include these checks. I'll make sure you have the opportunity to review the test plan so we describe the checks correctly.

Comment 7

[Robert Strong (they/them - no direct email)]

Note: I suggest doing a diff of a 64 bit install against an install that has updated from 32 to 64 bit. Off the top of my head the only files that should be different are the install.log, uninstall.log, and the uninstall.update files.