Closed Bug 1317672 Opened 5 years ago Closed 4 years ago

[meta] Fix gray marking assertion failures


(Core :: JavaScript: GC, defect)

Not set





(Reporter: jonco, Unassigned)


(Depends on 1 open bug)


Meta-bug to track fixing the problems shown up by the gray marking assertions we added in bug 1283634.
Depends on: 1303999
Depends on: 1298773, 1292852
Depends on: 1322539
Depends on: 1323241
Depends on: 1335117
Depends on: 1333498
Depends on: 1334618
Depends on: 1335751
Depends on: 1337502
Depends on: 1338623
Depends on: 1339770
Depends on: 1339814
Depends on: 1340499
Depends on: 1340604
Jon, I haven't seen any update on this bug or most related bugs in over a week, can you give an update here as we have bug 1336630 and bug 1334618 still failing frequently.  I do see some status in bug 1338623 and a reference to bug 1341065 (which is access denied for me).
Flags: needinfo?(jcoppeard)
I'm working on adding assertions that the gray marking state is valid before running the cycle collector in bug 1335751.  Currently these assertions are failing and I'm tracking down why.  It's slow going but I'm making progress.  I've eliminated several possibilities and added test code to the JS engine to prove that various gray marking machinery works correctly.
Flags: needinfo?(jcoppeard)
Depends on: 1343590
Status update: I'm still working on this.  I haven't managed to reproduce any of the bugs locally.  I'm working on tests and assertions to make sure the gray marking infrastructure is sound and works reliably.  So far I've turned up a bunch of problems which I'm working on fixing (see the bugs in this tree) but none that are going to fix these intermittent failures for sure.
update here, the intermittent gc:GRAY test failures all seem to be resolved, thanks for hacking on this.
(In reply to Joel Maher ( :jmaher) from comment #4)
Great news!
Depends on: 1349637
Depends on: 1350168
Depends on: 1350248
The gray marking assertion failures are fixed now.
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.