1317672 - [meta] Fix gray marking assertion failures

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Jon Coppeard (:jonco)]

Meta-bug to track fixing the problems shown up by the gray marking assertions we added in bug 1283634.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Jon, I haven't seen any update on this bug or most related bugs in over a week, can you give an update here as we have bug 1336630 and bug 1334618 still failing frequently.  I do see some status in bug 1338623 and a reference to bug 1341065 (which is access denied for me).

Comment 2

[Jon Coppeard (:jonco)]

I'm working on adding assertions that the gray marking state is valid before running the cycle collector in bug 1335751.  Currently these assertions are failing and I'm tracking down why.  It's slow going but I'm making progress.  I've eliminated several possibilities and added test code to the JS engine to prove that various gray marking machinery works correctly.

Comment 3

[Jon Coppeard (:jonco)]

Status update: I'm still working on this.  I haven't managed to reproduce any of the bugs locally.  I'm working on tests and assertions to make sure the gray marking infrastructure is sound and works reliably.  So far I've turned up a bunch of problems which I'm working on fixing (see the bugs in this tree) but none that are going to fix these intermittent failures for sure.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

update here, the intermittent gc:GRAY test failures all seem to be resolved, thanks for hacking on this.

Comment 5

[Jon Coppeard (:jonco)]

(In reply to Joel Maher ( :jmaher) from comment #4)
Great news!

Comment 6

[Jon Coppeard (:jonco)]

The gray marking assertion failures are fixed now.