1339770 - Add test code for weak map gray marking behaviour

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Jon Coppeard (:jonco)]

Attachment: test-weakmap-gray-marking

Here's a patch to add test code for weak map gray marking behaviour.

The rules are:
 - a value is marked black if both the map and the key are black
 - a value is marked gray if both the map and key are marked, but either or both are gray
 - a key is marked black if it has a black delegate and the map is black
 - a key is marked gray if both the map and delegate are marked, but either or both are gray

Comment 1

[Jon Coppeard (:jonco)]

Attachment: test-ccw-gray-unmarking

This is probably a bit paranoid, but check that we unmark gray CCWs when we look them up in different situations.

Comment 2

[Andrew McCreight [:mccr8]]

One thing that might be nice would be some kind of generic template with the bits of weak map logic that we could reuse rather than having at least 3 copies of the logic scattered around.

Comment 3

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8837546 [details] [diff] [review]
test-weakmap-gray-marking

Review of attachment 8837546 [details] [diff] [review]:
-----------------------------------------------------------------

That's very straightforward and nice.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/208a7d1895d7
Add jsapi tests for weak map gray marking r=sfink
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c921aea9d8e
Add tests for gray marking of CCWs r=sfink

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/208a7d1895d7
https://hg.mozilla.org/mozilla-central/rev/9c921aea9d8e