1317949 - Fails to build RTCCertificate.cpp with gcc 7.0

Status: RESOLVED DUPLICATE of bug 1335075

(Core :: WebRTC, defect, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

An experimental version of gcc 7 is available in Debian https://tracker.debian.org/pkg/gcc-7

Trying to build Firefox with it, it fails on the warning here:

/root/firefox-gcc-last/dom/media/webrtc/RTCCertificate.cpp:84:12: error: output truncated before the last format character [-Werror=format-length=]
   nsresult GenerateCertificate()
            ^~~~~~~~~~~~~~~~~~~
/root/firefox-gcc-last/dom/media/webrtc/RTCCertificate.cpp:77:58: note: format output 3 bytes into a destination of size 2
       snprintf(&buf[i * 2 + 3], 2, "%.2x", randomName[i]);
                                                          ^

Comment 1

[Paul Adenot (:padenot)]

jesup, does that seem legit? I think it is.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Looks good to my analysis.  Likely compiler bug.  Admittedly you really need to look...

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Sorry for the noise, seems that I need holidays :)