1320878 - Fix incorrect assertions in js/src/builtin/

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

gcc 7.0 complains about them:

/root/firefox-gcc-last/js/src/builtin/ModuleObject.cpp: In member function 'bool js::ModuleBuilder::processExport(js::frontend::ParseNode*)':
/root/firefox-gcc-last/js/src/builtin/ModuleObject.cpp:1162:57: error: ?: using integer constants in boolean context, the expression will always evaluate to 'true' [-Werror=int-in-bool-context]
     MOZ_ASSERT(pn->getArity() == pn->isKind(PNK_EXPORT) ? PN_UNARY : PN_BINARY);


                 from /root/firefox-gcc-last/obj-x86_64-pc-linux-gnu/js/src/Unified_cpp_js_src1.cpp:2:
/root/firefox-gcc-last/js/src/builtin/ReflectParse.cpp: In member function 'bool {anonymous}::ASTSerializer::exportDeclaration(js::frontend::ParseNode*, JS::MutableHandleValue)':
/root/firefox-gcc-last/js/src/builtin/ReflectParse.cpp:2143:57: error: ?: using integer constants in boolean context, the expression will always evaluate to 'true' [-Werror=int-in-bool-context]

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1320878 - Fix incorrect assertions in js/src/builtin/

Review commit: https://reviewboard.mozilla.org/r/96220/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96220/

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8815191 [details]
Bug 1320878 - Fix incorrect assertions in js/src/builtin/

https://reviewboard.mozilla.org/r/96220/#review96418

Great catch, thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bb030f09be5
Fix incorrect assertions in js/src/builtin/ r=bbouvier

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5bb030f09be5