1318507 - Minimize distance to WebGL idl

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1318507 - Minimize WebGL idl divergence. -

Review commit: https://reviewboard.mozilla.org/r/93862/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93862/

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1318507 - Merge some Buffer[Sub]Data entrypoints. -

Review commit: https://reviewboard.mozilla.org/r/93864/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93864/

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1318507 - Update implementation. -

Review commit: https://reviewboard.mozilla.org/r/93866/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93866/

Comment 4

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1318507 - Update sampler entrypoints to be non-nullable, and drop trivial WebGLContextUnchecked usages. -

Review commit: https://reviewboard.mozilla.org/r/93868/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93868/

Comment 6

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8811984 [details]
Bug 1318507 - Minimize WebGL idl divergence. -

https://reviewboard.mozilla.org/r/93862/#review94240

Comment 7

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8811985 [details]
Bug 1318507 - Merge some Buffer[Sub]Data entrypoints. -

https://reviewboard.mozilla.org/r/93864/#review94242

Comment 8

[Ethan Lin[:ethlin]]

Comment on attachment 8811986 [details]
Bug 1318507 - Update implementation. -

https://reviewboard.mozilla.org/r/93866/#review94442

Comment 9

[Ethan Lin[:ethlin]]

Comment on attachment 8811987 [details]
Bug 1318507 - Update sampler entrypoints to be non-nullable, and drop trivial WebGLContextUnchecked usages. -

https://reviewboard.mozilla.org/r/93868/#review94446

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d2850876b63
Minimize WebGL idl divergence. - r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0cbc9d8ef36
Merge some Buffer[Sub]Data entrypoints. - r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff8f08ed3a7c
Update implementation. - r=ethlin
https://hg.mozilla.org/integration/mozilla-inbound/rev/c19a7eb96ced
Update sampler entrypoints to be non-nullable, and drop trivial WebGLContextUnchecked usages. - r=ethlin
https://hg.mozilla.org/integration/mozilla-inbound/rev/76c1412d431f
SharedArrayBuffer must be wrapped in a view before being passed to WebGL.
https://hg.mozilla.org/integration/mozilla-inbound/rev/17ce37597d5c
Cherry-pick affected tests from top-of-tree.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1d2850876b63
https://hg.mozilla.org/mozilla-central/rev/a0cbc9d8ef36
https://hg.mozilla.org/mozilla-central/rev/ff8f08ed3a7c
https://hg.mozilla.org/mozilla-central/rev/c19a7eb96ced
https://hg.mozilla.org/mozilla-central/rev/76c1412d431f
https://hg.mozilla.org/mozilla-central/rev/17ce37597d5c

Comment 12

[Kelsey Gilbert [:jgilbert]]

Attachment: placeholder for all patches

Approval Request Comment
[Feature/Bug causing the regression]: webgl2
[User impact if declined]:
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
[Why is the change risky/not risky?]:
[String changes made/needed]:

Comment 13

[Gerry Chang [:gchang]]

Comment on attachment 8818748 [details]
placeholder for all patches

WebGL2 related patch. Beta51+ & Aurora52+. Should be in 51 beta 8.

Comment 14

[Carsten Book [:Tomcat]]

needs rebasing for aurora

Comment 15

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/15cb38704ced

Comment 16

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ee61ad2356b9