1318552 - Add accesskey for Folder Pane Toolbar

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Óvári]

Attachment: Thunderbird Folder Pane Toolbar keyboard shortcut.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20161028101142

Steps to reproduce:

Please add keyboard shortcut to "Folder Pane Toolbar" as shown in attachment.

_V_iew menu --> _T_oolbars --> Folder Pane Toolbar

Thank you

Comment 1

[Jorg K (CEST = GMT+2)]

Richard, could you take this one?

Comment 2

[Wayne Mery (:wsmwk)]

There have been past discussion of this in bugzilla. And this isn't a toolbar, but rather a column control. So I believe this bug is a duplicate of bug 1135536 :)

Note - this would be keyboard sequence, not a shortcut in the way we normally use the term.

Comment 3

[Richard Marti (:Paenglab)]

This bug is for the Folder Pane Toolbar which is the one which contains as default the Folder Views menulist.

Comment 4

[Wayne Mery (:wsmwk)]

Ah, version 51 :)  I was running 45.  Sorry.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: foldrPaneToolbarAccesskey.patch

F should work as accesskey. Or is there a other toolbar with this accesskey?

Comment 6

[:aceman]

Comment on attachment 8812240 [details] [diff] [review]
foldrPaneToolbarAccesskey.patch

Review of attachment 8812240 [details] [diff] [review]:
-----------------------------------------------------------------

Did I forget an accesskey? :)

Comment 7

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/0299a87cb9807ba92c064ca0eaa349e59a658ce6

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 8812240 [details] [diff] [review]
foldrPaneToolbarAccesskey.patch

[Approval Request Comment]
User impact if declined: no accesskey
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

I think the string freeze is later, so asking for approval.

Comment 9

[Jorg K (CEST = GMT+2)]

(In reply to Richard Marti (:Paenglab) from comment #8)
> I think the string freeze is later, so asking for approval.
This is a little unclear. In any case I was asked to land all the string changes at the same time, so that would be in early December. I'll revisit this.

Comment 10

[Jorg K (CEST = GMT+2)]

Comment on attachment 8812240 [details] [diff] [review]
foldrPaneToolbarAccesskey.patch

Aurora (TB 52):
https://hg.mozilla.org/releases/comm-aurora/rev/cd57b8da6c2178ffad8a843bc2b2d6b3d65f8d51