1318604 - Intermittent test_ext_runtime_connect.html | test_ext_runtime_connect2.html | test_ext_storage_tab.html | [SimpleTest.finish()] No checks actually run. (You need to call ok(), is(), or similar functions at least once. Make sure you use SimpleTest....

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=39425723&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/YpWhhCVeTYa0K1LEV6_xUg/runs/0/artifacts/public/logs/live_backing.log

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1318604: Don't add task for OOP preference initialization.

Adding mochitest tasks from head scripts turns out to cause unpredictable
timing issues, where the initial add_task() call sometimes causes tests to
begin running before the main test script has loaded, and had a chance to add
its tasks. While I'd still prefer to do this initialization in a task, it's
not worth the intermittent failures it causes.

Review commit: https://reviewboard.mozilla.org/r/94066/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94066/

Comment 5

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8812238 [details]
Bug 1318604: Don't add task for OOP preference initialization.

https://reviewboard.mozilla.org/r/94064/#review94226

Comment 6

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8812238 [details]
Bug 1318604: Don't add task for OOP preference initialization.

https://reviewboard.mozilla.org/r/94066/#review94230

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22ae4fe2094f
Don't add task for OOP preference initialization. r=mixedpuppy

Comment 8

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/42a9728ad5f8b61596cbca5c3b7d83c8e84dc74c
Bug 1318604: Don't add task for OOP preference initialization. r=mixedpuppy

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/22ae4fe2094f

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/42a9728ad5f8