1318705 - Combine nsXULPopupManager popup lists

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Neil Deakin]

Attachment: Combine popup lists

Two separate lists of popups are used: mPopups and mNoHidePanels. There isn't really a need for this distinction and some code can be simplified by combining them into a single list.

Comment 1

[Neil Deakin]

Attachment: Combine popup lists, v2

Comment 2

[Robin Steuber (she/her) [:bytesized]]

Comment on attachment 8844424 [details] [diff] [review]
Combine popup lists, v2

Review of attachment 8844424 [details] [diff] [review]:
-----------------------------------------------------------------

I had quite a hard time reviewing this, as I only have a little experience in some areas that this patch touches. From what I can tell, however, the patch looks fine to me.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a57d843357e2
combine the two lists of open popups in nsXULPopupManager into a single list to make iterating and managing them easier. Instead a noautohide flag is used to distinguish what used to be the difference between the lists, r=ksteuber

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a57d843357e2