1319004 - Update ANGLE to chromium/2924

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Ethan Lin[:ethlin]]

The new ANGLE fixes some crash problems and conformance tests. The latest version is 2924 and I'll update it.

Comment 1

[Ethan Lin[:ethlin]]

Attachment: Part1. Update ANGLE/2924

Update to ANGLE/2924.

Comment 2

[Ethan Lin[:ethlin]]

Attachment: Part2. Fix try crash problem

We had workaround in ReadPixels for ANGLE. It seems like we don't need the workaround anymore since ANGLE has some fixes, like [1], [2].

[1] https://github.com/google/angle/commit/0a337e93bf945dc76d8d4f77912ea00e25986bb3
[2] https://github.com/google/angle/commit/ece7c5a848df6b64e361184bbf3a9739b209e40c

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8813532 [details] [diff] [review]
Part1. Update ANGLE/2924

Review of attachment 8813532 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, I /totally/ reviewed this whole cset. :)

Comment 4

[Ethan Lin[:ethlin]]

Attachment: Fix angle build script (for mozilla/angle)

Remove some files from UNIFIED_SOURCES which are not compatible with unified build.

Comment 5

[Ethan Lin[:ethlin]]

Attachment: Fix build break after angle update (for mozilla/angle)

Fix build break on windows for ANGLE.

Comment 6

[Ethan Lin[:ethlin]]

(In reply to Ethan Lin[:ethlin] from comment #5)
> Created attachment 8813552 [details] [diff] [review]
> Fix build break after angle update (for mozilla/angle)
> 
> Fix build break on windows for ANGLE.

try result of the build break:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5eb322f99df7f89f48c32f4ed9eff53b1f96ecc7&selectedJob=31551538

Comment 7

[Ethan Lin[:ethlin]]

Attachment: Fix angle build script (for mozilla/angle)

Per dicussion with Morris, we just need this fix.

Comment 8

[Ethan Lin[:ethlin]]

so far try result looks good:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=487a2e93b3840b6ef9f8eb48ec58335cd70ea74a

Comment 9

[Ethan Lin[:ethlin]]

Attachment: Part1. Update ANGLE/2924 (carry r+: jgilbert)

Upload new patch due the change of ANGLE/gyp_mozbuild.

Comment 10

[Peter Chang[:pchang]]

milan, we would like to land this in central this week. If everything goes well, we would like to uplift this to aurora/beta. Do you have any concern?

Comment 11

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Peter Chang[:pchang] from comment #10)
> milan, we would like to land this in central this week. If everything goes
> well, we would like to uplift this to aurora/beta. Do you have any concern?

Well, it is somewhat scary, but let's land it on central this week, aurora early next week, and beta towards the end of the week following, assuming nothing bad shows up.

Comment 12

[Ethan Lin[:ethlin]]

try result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0fe2a39fb93a9e0a26ac6890a11b4e7cd34682f4&filter-searchStr=gl

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fcf8c42bf382
Update to ANGLE/2924. r=jgilbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/797ee4b5a948
Remove workaround for ANGLE. r=jgilbert

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fcf8c42bf382
https://hg.mozilla.org/mozilla-central/rev/797ee4b5a948

Comment 15

[Philip Chee]

I'm experiencing this compile failure:

c:/t1/hg/comm-central/mozilla/gfx/angle/src/libANGLE/renderer/Format_table_autogen.cpp(28): error C2131: expression did not evaluate
 to a constant
c:\t1\hg\comm-central\mozilla\gfx\angle\src\libANGLE/renderer/Format.h(81): note: a non-constant (sub-)expression was encountered
c:/t1/hg/comm-central/mozilla/gfx/angle/src/libANGLE/renderer/Format_table_autogen.cpp(149): fatal error C1903: unable to recover fr
om previous error(s); stopping compilation
c:/t1/hg/comm-central/mozilla/config/rules.mk:963: recipe for target 'Unified_cpp_angle_src_libANGLE9.obj' failed
mozmake[4]: *** [Unified_cpp_angle_src_libANGLE9.obj] Error 2

Any hints?

Comment 16

[Philip Chee]

more context

c:/t1/hg/comm-central/mozilla/gfx/angle/src/libANGLE/renderer/Format_table_autogen.cpp(28): error C2131: expression did not evaluate
 to a constant
c:\t1\hg\comm-central\mozilla\gfx\angle\src\libANGLE/renderer/Format.h(81): note: a non-constant (sub-)expression was encountered
c:/t1/hg/comm-central/mozilla/gfx/angle/src/libANGLE/renderer/Format_table_autogen.cpp(149): fatal error C1903: unable to recover fr
om previous error(s); stopping compilation
c:/t1/hg/comm-central/mozilla/config/rules.mk:963: recipe for target 'Unified_cpp_angle_src_libANGLE9.obj' failed
mozmake[4]: *** [Unified_cpp_angle_src_libANGLE9.obj] Error 2
mozmake[4]: *** Waiting for unfinished jobs....

Comment 17

[Philip Chee]

Looks like I need VS 2015 Update 3
I only have Update 3

Comment 18

[Philip Chee]

note to self:
The "correct" fix is of course to use a better compiler but VS2015 is a supported target so the correct fix would be to make all of these jump tables static const instead of constexpr.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

FYI, bug 1319901 tracks enforcing Update 3 as the minimum version supported.

Ethan, it looks like we need to backport this to at least Aurora52. Do we need to go back further than that? Please nominate accordingly.

Comment 20

[Kelsey Gilbert [:jgilbert]]

(In reply to Philip Chee from comment #17)
> Looks like I need VS 2015 Update 3
> I only have Update 3

Sorry, which version do you have that *doesn't* work? I assume u2?


We should take a stab at getting this building with u2 before uplifting to Aurora.

Comment 21

[Peter Chang[:pchang]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #19)
> FYI, bug 1319901 tracks enforcing Update 3 as the minimum version supported.
> 
> Ethan, it looks like we need to backport this to at least Aurora52. Do we
> need to go back further than that? Please nominate accordingly.

Yes, we need this for Aurora and uplift to beta51 few days later if no bad things happen.

(In reply to Jeff Gilbert [:jgilbert] from comment #20)
> (In reply to Philip Chee from comment #17)
> > Looks like I need VS 2015 Update 3
> > I only have Update 3
> 
> Sorry, which version do you have that *doesn't* work? I assume u2?
> 
> 
> We should take a stab at getting this building with u2 before uplifting to
> Aurora.
I'm building this patch with 2015u2 and will update later.

Comment 22

[Peter Chang[:pchang]]

I got the same error in comment 16 with 20155u2.

Comment 23

[Ethan Lin[:ethlin]]

Comment on attachment 8813597 [details] [diff] [review]
Part1. Update ANGLE/2924 (carry r+: jgilbert)

Approval Request Comment
[Feature/Bug causing the regression]: webgl2
[User impact if declined]: some webgl api may malfunction
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: newer ANGLE should fix some bugs
[String changes made/needed]: none

Comment 24

[Ethan Lin[:ethlin]]

Comment on attachment 8813539 [details] [diff] [review]
Part2. Fix try crash problem

Approval Request Comment
[Feature/Bug causing the regression]: webgl2
[User impact if declined]: some webgl api may malfunction
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: newer ANGLE should fix some bugs
[String changes made/needed]: none

Comment 25

[Philip Chee]

I had VS2015 Update 2. Didn't work Updated to VS2015 Update 3. Compiles ANGLE fine.

Comment 26

[Julien Cristau [:jcristau]]

Comment on attachment 8813597 [details] [diff] [review]
Part1. Update ANGLE/2924 (carry r+: jgilbert)

ANGLE update for aurora52.  wcpgw.

Comment 27

[Julien Cristau [:jcristau]]

Comment on attachment 8813539 [details] [diff] [review]
Part2. Fix try crash problem

remove workaround for ANGLE bug after updating it, for aurora52

Comment 28

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/faa34b255f45
https://hg.mozilla.org/releases/mozilla-aurora/rev/a8d6dc1f3555

Comment 30

[Peter Chang[:pchang]]

Ryan, we would like to uplift patches in Comment 28 to beta51. I made a patch in bug 1321094 attachment 8815609 [details] to fix compiler error with VS2015u2. I got build passed in my local. But I'm not sure how could I make sure it works for beta. Any suggestion?

Comment 31

[Ryan VanderMeulen [:RyanVM]]

The choice of compiler we use to build with is actually controlled via in-tree manifests these days. You should be able to push your patch to Try on top of Beta have things Just Work.

Comment 32

[Peter Chang[:pchang]]

The compiler problem for beta was solved and I didn't hear negative things from aurora channel about new ANGLE update.

Comment 33

[Peter Chang[:pchang]]

Comment on attachment 8813597 [details] [diff] [review]
Part1. Update ANGLE/2924 (carry r+: jgilbert)

Approval Request Comment
[Feature/Bug causing the regression]: webgl2
[User impact if declined]: some webgl api may malfunction
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: newer ANGLE should fix some bugs
[String changes made/needed]: none

Comment 34

[Peter Chang[:pchang]]

Comment on attachment 8813539 [details] [diff] [review]
Part2. Fix try crash problem

Approval Request Comment
[Feature/Bug causing the regression]: webgl2
[User impact if declined]: some webgl api may malfunction
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: newer ANGLE should fix some bugs
[String changes made/needed]: none

Comment 35

[Gerry Chang [:gchang]]

Comment on attachment 8813539 [details] [diff] [review]
Part2. Fix try crash problem

WebGL 2 will be shipped in 51. Angle update is important to this. Beta51+. Should be in 51 beta 8.

Comment 36

[Carsten Book [:Tomcat]]

remote:   https://hg.mozilla.org/releases/mozilla-beta/rev/7e4b771905373aba5a8b0733389ba5d1855c4158
remote:   https://hg.mozilla.org/releases/mozilla-beta/rev/bd43ce1d7c258f727eec694b8e7d72f072c8905c