1320471 - Can't build under Windows 10 since update to ANGLE/2924

Status: RESOLVED DUPLICATE of bug 1321094

(Core :: Graphics: CanvasWebGL, defect)

Description

[Bill Gianopoulos [:WG9s]]

After landing of bug 1319004 I get the following errors on my Windows build:

66:38.65 c:/Users/wag/mozilla/mozilla2/gfx/angle/src/libANGLE/renderer/Format_table_autogen.cpp(28): error C2131: expression did not evaluate to a constant
66:38.65 c:\Users\wag\mozilla\mozilla2\gfx\angle\src\libANGLE/renderer/Format.h(81): note: a non-constant (sub-)expression was encountered
66:38.65 c:/Users/wag/mozilla/mozilla2/gfx/angle/src/libANGLE/renderer/Format_table_autogen.cpp(149): fatal error C1903: unable to recover from previous error(s); stopping compilation

Comment 1

[Philip Chee]

This is a bug in VS2015 Update 2 fixed in Update 3
Chromium project encountered the same problem when updated to ANGLE/2924
Their fix was to make VS2015 Update 3 a minimum requirement.
However until now I could continue to build with VS2015 Update 2
Spent several hours downloading Update 3 on my slow internet connection.

Comment 2

[Bill Gianopoulos [:WG9s]]

(In reply to Philip Chee from comment #1)
> This is a bug in VS2015 Update 2 fixed in Update 3
> Chromium project encountered the same problem when updated to ANGLE/2924
> Their fix was to make VS2015 Update 3 a minimum requirement.
> However until now I could continue to build with VS2015 Update 2
> Spent several hours downloading Update 3 on my slow internet connection.

OK.  I was confused by 2 things here.

1.  typo in your comment in the other bug.  you said update 3 is required and you were running update 3.  I guess you meant you were running update 2.

2.  I am up to date on Windows update and have it set to update windows and other Microsoft products.  One would expect this would have auto-updated.

Comment 3

[Bill Gianopoulos [:WG9s]]

I can verify that upgrading to the latest version of Visual Studio Community 2015 fixes this issue.

Comment 4

[Bill Gianopoulos [:WG9s]]

(In reply to Bill Gianopoulos [:WG9s] from comment #2)
> 2.  I am up to date on Windows update and have it set to update windows and
> other Microsoft products.  One would expect this would have auto-updated.

OK I "think" I have figured this out as well.  It seems I have been running Visual Studio on an expired 30 day evaluation license.  It seems if you just kind of follow the installation instructions on the Windows Build Prerequisites WIKI page and never actually run Visual Studios via the normal windows GUI launch and only use it to build Mozilla code, it works just fine that way indefinitely, but is actually running on a 30 day evaluation license that oddly enough will continue to work for build purposes even after the expiration.  However, it will not automatically update via Windows Update.  SO, you need to launch the Visual studios gui and run the first run procedure which will walk you through either associating it with an existing account or creating a new one to get a non-expiring license.  Of course, I am not 100% certain this will auto-update either, but it seems much more likely that a licensed version will than an unlicensed one.

Comment 5

[Bill Gianopoulos [:WG9s]]

I updated the WIKI page with a warning about running the first-run procedure.