1319103 - unrelated bugs getting added to dependency graph

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[[e-mail] (:bhearsum)]

I've been using the Dependency Graph for the past month or so to get a view of the project tracked by bug 1278974. Specifically, https://bugzilla.mozilla.org/showdependencygraph.cgi?id=1278974&display=tree&rankdir=TB. Everything was working fine for awhile, but today I'm starting to see unrelated bugs sometimes show up in the graph. Sometimes it's a handful, sometimes it's hundreds. Here's a few examples:
https://people-mozilla.org/~bhearsum/sattap/5a5967c6.png (what it should look like)
https://people-mozilla.org/~bhearsum/sattap/57f71947.png (a massive number of extras)
https://people-mozilla.org/~bhearsum/sattap/ebb08e3f.png (a handful of extras)

Until about 10 days ago, none of the bugs in the graph were resolved, so that's something that's changed recently, but I'm not sure it's related at all.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: Pull Request

Note: This will only manifest under mod_perl. Several variables were declared with our(), which means they are global. As a side effect, they're not cleared out between requests.

This was never noticed before because usage of dependendcygraph is smallish, and prior to my initial memory leak work the webheads didn't live very long.

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 8812867 [details] [review]
Pull Request

r=dkl

Comment 3

[Dylan Hardison [:dylan] (he/him)]

To [e-mail]:mozilla-bteam/bmo.git
   6b551fb..78eac22  master -> master