Enable dormant for dom/media/mediasource/test/test_Eviction_mp4.html

NEW
Assigned to

Status

()

P3
normal
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jya)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

2 years ago
Dormant should be invisible to the web. We will figure out how dormant causes test failures.
(Reporter)

Updated

2 years ago
Assignee: nobody → jwwang
Blocks: 1286129
Depends on: 1318982
Priority: -- → P3
(Reporter)

Comment 1

2 years ago
Got this error when dormant is enabled:
120 INFO TEST-UNEXPECTED-FAIL | dom/media/mediasource/test/test_Eviction_mp4.html | Shouldn't throw another time when data can be evicted

This is because:
DormantState::Enter -> MDSM::Reset -> MediaDecoderReaderWrapper::ResetDecode -> MediaFormatReader::ResetDecode -> DecoderData::ResetDemuxer -> MediaSourceTrackDemuxer::Reset -> TrackBuffersManager::Seek -> TrackBuffersManager::ResetEvictionIndex which changes mEvictionIndex.
Flags: needinfo?(jyavenard)
(Assignee)

Comment 2

2 years ago
hmmm... interesting problem...

either we keep having dormant disable for this test.

Or we always allow an append to succeed after a seek, even if we think the buffer is full, eviction will still happen later in the cycle, just not synchronously.
Flags: needinfo?(jyavenard)
(Reporter)

Comment 3

2 years ago
I guess the later has less impact on the user.
(Reporter)

Comment 4

2 years ago
Hi Jya,
Please take this bug since this is your domain.
Assignee: jwwang → jyavenard
(Reporter)

Updated

2 years ago
Blocks: 1325302
(Reporter)

Updated

2 years ago
No longer blocks: 1286129
You need to log in before you can comment on or make changes to this bug.