Remove the misc-use-override.KeepVirtual declaration in .clang-tidy file

RESOLVED FIXED in Firefox 53

Status

defect
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: sylvestre, Assigned: sylvestre)

Tracking

unspecified
mozilla53
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
+++ This bug was initially created as a clone of Bug #1158656 +++

Looks like the option was never merged
https://reviews.llvm.org/D9285#224690
Assignee

Updated

3 years ago
Assignee: nobody → sledru
Assignee

Updated

3 years ago
Depends on: 1319396

Comment 2

3 years ago
mozreview-review
Comment on attachment 8813141 [details]
Bug 1319393 - Remove the misc-use-override.KeepVirtual declaration in .clang-tidy file

https://reviewboard.mozilla.org/r/94664/#review94942
Attachment #8813141 - Flags: review?(ehsan) → review+

Comment 3

3 years ago
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/052fdfd28e7a
Remove the misc-use-override.KeepVirtual declaration in .clang-tidy file r=Ehsan

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/052fdfd28e7a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53

Updated

Last year
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.