Closed Bug 1319393 Opened 5 years ago Closed 5 years ago

Remove the misc-use-override.KeepVirtual declaration in .clang-tidy file

Categories

(Firefox Build System :: Source Code Analysis, defect)

Product:
Firefox Build System
Component:
Source Code Analysis
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox53 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(1 file)

Bug 1319393 - Remove the misc-use-override.KeepVirtual declaration in .clang-tidy file
58 bytes, text/x-review-board-request
ehsan.akhgari
: review+
Details 
+++ This bug was initially created as a clone of Bug #1158656 +++

Looks like the option was never merged
https://reviews.llvm.org/D9285#224690
Assignee: nobody → sledru
Blocks: c++11-migration
Depends on: 1319396
Comment on attachment 8813141 [details]
Bug 1319393 - Remove the misc-use-override.KeepVirtual declaration in .clang-tidy file

https://reviewboard.mozilla.org/r/94664/#review94942
Attachment #8813141 - Flags: review?(ehsan) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/052fdfd28e7a
Remove the misc-use-override.KeepVirtual declaration in .clang-tidy file r=Ehsan
https://hg.mozilla.org/mozilla-central/rev/052fdfd28e7a
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.