1319410 - View source: don't error-highlight comments with dashes

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P3)

Description

[Simon Pieters [:zcorpan]]

See https://twitter.com/FakeUnicode/status/800808929554857984

There should be no red. :-)

This was changed in WHATWG HTML some time ago and implemented by Mike Smith in the Validator.nu HTML parser:

https://github.com/whatwg/html/issues/1351

https://github.com/validator/validator/commit/8c02230f0d9cc2d67015d5a7a6807843a0512704
https://github.com/validator/validator/commit/0c326a3a43cde16443aafa127078a836adf9e3a7
https://github.com/validator/validator/commit/3f553406c97d3c6cd4392a029c6d8b822c5e2ec1
https://github.com/validator/validator/commit/cd2aaa74e07c0fdbea9b5f1483568428eef578ad
https://github.com/validator/validator/commit/fd36bc6dd44902bc57228cbb0810cf40563f09b3

https://github.com/whatwg/html/pull/1356#issuecomment-222793570 has test cases.

Comment 1

[Andrew Overholt [:overholt]]

Henri, can you take a look here?

Comment 2

[Henri Sivonen (:hsivonen)]

I'll take a look. Keeping myself needinfoed to keep this visible.

Comment 3

[Simon Pieters [:zcorpan]]

Also https://github.com/validator/htmlparser/commit/520065e5f59872c91cce8f1dac5ef039f550fe0f

Comment 5

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1319410 - Make consecutive hyphens in comments a non-error

Also allow <!--> at (IE conditional) comment end

See https://github.com/whatwg/html/pull/1356
See https://github.com/whatwg/html/pull/1456

Comment 6

[Henri Sivonen (:hsivonen)]

The patch needs to be refreshed with the results of https://github.com/validator/htmlparser/pull/18 before landing.

Comment 7

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1319410 fixup - Stay in the COMMENT_LESSTHAN state, annotate fall-throughs.

Comment 8

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=58de3833568d349180009b5a6566b1aa23477ab5

Comment 9

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1319410 test - "--" in a comment is non-error but "<!--" in a comment is an error.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b33e3f54b58
Make consecutive hyphens in comments a non-error r=smaug
https://hg.mozilla.org/integration/autoland/rev/0b241b7f07e9
fixup - Stay in the COMMENT_LESSTHAN state, annotate fall-throughs. r=smaug
https://hg.mozilla.org/integration/autoland/rev/d75852f907a6
test - "--" in a comment is non-error but "<!--" in a comment is an error. r=smaug

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5b33e3f54b58
https://hg.mozilla.org/mozilla-central/rev/0b241b7f07e9
https://hg.mozilla.org/mozilla-central/rev/d75852f907a6

Comment 12

[Henri Sivonen (:hsivonen)]

https://github.com/validator/htmlparser/commit/6c06ef858a36192ebc8533f90f6fa25379cef6f8
https://github.com/validator/htmlparser/commit/4fa8e69518171648ec50a4bb7c50c02269021b44