Closed
Bug 1726374
Opened 3 years ago
Closed 3 years ago
Ensure that the View Source highlighter deals properly with new comment states
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
93 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox-esr91 | --- | unaffected |
| firefox91 | --- | unaffected |
| firefox92 | --- | unaffected |
| firefox93 | --- | fixed |
People
(Reporter: hsivonen, Assigned: hsivonen)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
Bug 1319410 added new states to the tokenizer state enumeration. The result looked OK, but the View Source highlighter is still unaware of those states.
Audit the highlighter and make it aware as appropriate.
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Has Regression Range: --- → yes
|
||
Comment 2•3 years ago
|
||
Type: task → defect
|
|
||
Comment 3•3 years ago
|
||
Set release status flags based on info from the regressing bug 1319410
status-firefox91:
--- → unaffected
status-firefox92:
--- → unaffected
status-firefox93:
--- → affected
status-firefox-esr78:
--- → unaffected
status-firefox-esr91:
--- → unaffected
Pushed by hsivonen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8370f995a458 Correctly highlight <!-- a <!-->b in View Source. r=smaug
|
||
Comment 5•3 years ago
•
|
||
Backed out changeset 8370f995a458 (bug 1726374) for causing reftest failures in view-source:bug1319410-1.html
https://hg.mozilla.org/integration/autoland/rev/cd44c6ac22eed9a005586a55d006764a72034aaa
Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&revision=8370f995a45832978e46e88dd3ec223c306e0560&selectedTaskRun=TpAx-ERkQJq5vueEAJ2raA.0
Failure log:
https://treeherder.mozilla.org/logviewer?job_id=348916048&repo=autoland&lineNumber=21495
Flags: needinfo?(hsivonen)
Pushed by hsivonen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9f65057f2229 Correctly highlight <!-- a <!-->b in View Source. r=smaug
|
|
||
Updated•3 years ago
|
Keywords: regression
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
|
|
Assignee | |
Updated•1 month ago
|
Flags: needinfo?(hsivonen)
You need to log in
before you can comment on or make changes to this bug.
Description
•