1319449 - image_builder exports empty images without failing

Status: RESOLVED FIXED

(Taskcluster Graveyard :: Docker Images, defect)

Description

[Jonas Finnemann Jensen (:jonasfj)]

Similar to bug 1318466, but in:
  https://tools.taskcluster.net/task-inspector/#Zlmn6ph4TJqY-J9r4jx5cg/0

In this case we export an image that is completely empty.
Issue in bug 1318466 the image.tar.zst was actually an encoded error message.
There is no error message here, otherwise it's very similar.

Comment 1

[Jonas Finnemann Jensen (:jonasfj)]

Just ran this 4 times without getting an error. I guess the solution here is to check that the build log
from docker ends with: "^Successfully built"
And checking that the image size is large than 1kb.

Comment 2

[Jonas Finnemann Jensen (:jonasfj)]

Okay, seems:
  set -o pipefail
Will do a lot to make my tests pass :)

Comment 3

[Jonas Finnemann Jensen (:jonasfj)]

Attachment: Bug 1319449 - Set -o pipefail and other robustness improvements for image_builder.

Review commit: https://reviewboard.mozilla.org/r/94822/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94822/

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8813421 [details]
Bug 1319449 - Set -o pipefail and other robustness improvements for image_builder.

https://reviewboard.mozilla.org/r/94822/#review95250

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18a7e57308ae
Set -o pipefail and other robustness improvements for image_builder. r=dustin

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/18a7e57308ae