Closed Bug 1319449 Opened 3 years ago Closed 3 years ago

image_builder exports empty images without failing

Categories

(Taskcluster Graveyard :: Docker Images, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla53

People

(Reporter: jonasfj, Assigned: jonasfj)

References

Details

Attachments

(1 file)

Similar to bug 1318466, but in:
  https://tools.taskcluster.net/task-inspector/#Zlmn6ph4TJqY-J9r4jx5cg/0

In this case we export an image that is completely empty.
Issue in bug 1318466 the image.tar.zst was actually an encoded error message.
There is no error message here, otherwise it's very similar.
Blocks: 1266624
Just ran this 4 times without getting an error. I guess the solution here is to check that the build log
from docker ends with: "^Successfully built"
And checking that the image size is large than 1kb.
Okay, seems:
  set -o pipefail
Will do a lot to make my tests pass :)
Assignee: nobody → jopsen
Comment on attachment 8813421 [details]
Bug 1319449 - Set -o pipefail and other robustness improvements for image_builder.

https://reviewboard.mozilla.org/r/94822/#review95250
Attachment #8813421 - Flags: review?(dustin) → review+
Keywords: checkin-needed
Pushed by dmitchell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/18a7e57308ae
Set -o pipefail and other robustness improvements for image_builder. r=dustin
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/18a7e57308ae
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Product: Taskcluster → Taskcluster Graveyard
You need to log in before you can comment on or make changes to this bug.