1319512 - Disable non-standard expression closure on nightly-only

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Tooru Fujisawa [:arai]]

Just like bug 1293305, we could disable it only on nightly, with runtime flag,
and keep tests working with testing function to enable it (enableExprClosure).

some tests that want to test expression closure should call enableExprClosure,
and other tests that don't need expression closure should be rewritten in bug 1313490.

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: Disable expression closures on Nightly

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: Adjust expression closure tests so they fail

A while ago we had a few failures on Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd5621a92f4134d19781cf0881b097d8dde80de1&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&selectedJob=144000446

I am going to rerun this later, to see if this is real.

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 8928479 [details] [diff] [review]
Adjust expression closure tests so they fail

Review of attachment 8928479 [details] [diff] [review]:
-----------------------------------------------------------------

Great we can turn this off finally. We just need to remember to remove these tests when we remove expression closures.

::: js/src/tests/js1_8_5/reflect-parse/expressionClosures.js
@@ +1,1 @@
> +// |reftest| skip-if(!xulRuntime.shell) skip-if(!release_or_beta)

Does this work or should it be:

// |reftest| skip-if(!xulRuntime.shell || !release_or_beta)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/261ebf2e8bbd
Disable expression closures on Nightly. r=jandem
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d8aeee2633f
Adjust expression closure tests. r=jandem

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/261ebf2e8bbd
https://hg.mozilla.org/mozilla-central/rev/8d8aeee2633f

Comment 7

[Kohei Yoshino [:kohei]]

Updated the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2015/expression-closure-support-will-be-removed/

Comment 8

[Jan de Mooij [:jandem]]

Tom, what do you want to do here on beta/release? Our options are:

(1) Disable expression closures unconditionally on Nightly so this will ride the trains.
(2) Uplift a patch after the merge.
(3) Disable expression closures on beta 58 (too late for that now I guess).
(4) Remove expression closures on Nightly.

I don't care too much, but we should do one of these so this will stay disabled on beta.

Comment 9

[Tom S. (please needinfo tschuster)]

Let's go with 1.

Comment 10

[Florian Scholz (Open Web Docs)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1426519#c11