Closed Bug 1319512 Opened 3 years ago Closed 2 years ago
Disable non-standard expression closure on nightly-only
Just like bug 1293305, we could disable it only on nightly, with runtime flag, and keep tests working with testing function to enable it (enableExprClosure). some tests that want to test expression closure should call enableExprClosure, and other tests that don't need expression closure should be rewritten in bug 1313490.
A while ago we had a few failures on Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd5621a92f4134d19781cf0881b097d8dde80de1&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&selectedJob=144000446 I am going to rerun this later, to see if this is real.
Attachment #8928479 - Flags: review?(jdemooij)
Attachment #8928478 - Flags: review?(jdemooij) → review+
Comment on attachment 8928479 [details] [diff] [review] Adjust expression closure tests so they fail Review of attachment 8928479 [details] [diff] [review]: ----------------------------------------------------------------- Great we can turn this off finally. We just need to remember to remove these tests when we remove expression closures. ::: js/src/tests/js1_8_5/reflect-parse/expressionClosures.js @@ +1,1 @@ > +// |reftest| skip-if(!xulRuntime.shell) skip-if(!release_or_beta) Does this work or should it be: // |reftest| skip-if(!xulRuntime.shell || !release_or_beta)
Attachment #8928479 - Flags: review?(jdemooij) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/261ebf2e8bbd Disable expression closures on Nightly. r=jandem https://hg.mozilla.org/integration/mozilla-inbound/rev/8d8aeee2633f Adjust expression closure tests. r=jandem
Updated the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2015/expression-closure-support-will-be-removed/
Tom, what do you want to do here on beta/release? Our options are: (1) Disable expression closures unconditionally on Nightly so this will ride the trains. (2) Uplift a patch after the merge. (3) Disable expression closures on beta 58 (too late for that now I guess). (4) Remove expression closures on Nightly. I don't care too much, but we should do one of these so this will stay disabled on beta.
Let's go with 1.
You need to log in before you can comment on or make changes to this bug.