Remove leftover chrome://browser/skin/syncProgress-*.png files

RESOLVED FIXED in Firefox 53

Status

()

Firefox
Sync
P2
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: florian, Assigned: pass2pawan)

Tracking

({good-first-bug})

unspecified
Firefox 53
good-first-bug
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 months ago
Bug 1201331 (https://hg.mozilla.org/mozilla-central/rev/661a531f5dee) removed references to these files without removing them from the tree:

chrome://browser/skin/syncProgress-menuPanel.png	           linux,mac,windows
chrome://browser/skin/syncProgress-menuPanel@2x.png        linux,mac,windows
chrome://browser/skin/syncProgress-toolbar-XPVista7.png	   windows
chrome://browser/skin/syncProgress-toolbar-XPVista7@2x.png windows
chrome://browser/skin/syncProgress-toolbar-inverted.png    linux,mac,windows
chrome://browser/skin/syncProgress-toolbar-inverted@2x.png mac,windows
chrome://browser/skin/syncProgress-toolbar.png             linux,mac,windows
chrome://browser/skin/syncProgress-toolbar@2x.png          mac,windows
Priority: -- → P2
(Assignee)

Comment 1

5 months ago
is the  bug simply removing those files ?

Comment 2

5 months ago
(In reply to pass2pawan from comment #1)
> is the  bug simply removing those files ?

Yep - and probably a reference to these files in a manifest.
(Reporter)

Comment 3

5 months ago
(In reply to pass2pawan from comment #1)
> is the  bug simply removing those files ?

Yes, it's removing these files, and the references in jar.mn package manifests, see http://searchfox.org/mozilla-central/search?q=syncProgress-

Note: the syncProgress-horizontalbar.png and syncProgress-horizontalbar@2x.png files are still used.
Keywords: good-first-bug
(Assignee)

Comment 4

5 months ago
do i need to build firefox again after i remove these files ? And i want to know if there's a way to build individual folders like 'mach build browser '
(Assignee)

Comment 5

5 months ago
Created attachment 8818225 [details] [diff] [review]
Bug-1319539.patch
(Assignee)

Updated

5 months ago
Attachment #8818225 - Flags: review?(florian)
(Reporter)

Comment 6

5 months ago
Comment on attachment 8818225 [details] [diff] [review]
Bug-1319539.patch

Review of attachment 8818225 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks!
Attachment #8818225 - Flags: review?(florian) → review+
(Assignee)

Comment 7

5 months ago
will i be assigned the bug ?
(Reporter)

Comment 8

5 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f769a52d71d0
(Reporter)

Comment 9

5 months ago
(In reply to pass2pawan from comment #7)
> will i be assigned the bug ?

Yes, I'm assigning the bug to you. I pushed the patch to try to verify that things work OK on all platforms, as I assume you tested locally on only one of them. Assuming try is green, I'll push your patch to mozilla-inbound in the next day or two.
Assignee: nobody → pass2pawan
(Reporter)

Comment 10

5 months ago
The try server results show bc test failures (browser_dragdropURL.js | Uncaught exception - at chrome://mochikit/content/tests/SimpleTest/EventUtils.js:2063 - TypeError: aDataTransfer is undefined), they are unrelated and have been fixed by https://hg.mozilla.org/integration/mozilla-inbound/rev/b52932a0811b
(Reporter)

Comment 11

5 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b075bfc532f327849e2bb9923cf9df2c9c82c99
Bug 1319539 - Remove leftover chrome://browser/skin/syncProgress-*.png files. r=florian

Comment 12

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4b075bfc532f
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
(Reporter)

Comment 13

5 months ago
Thanks for fixing this bug Pawan! If you would be interested in other similar bugs, you can have a look at the dependencies of bug 1316187 (https://bugzilla.mozilla.org/showdependencytree.cgi?id=1316187&hide_resolved=1)
when this bug landed our installer size reduced for windows- yay!

== Change summary for alert #4517 (as of December 14 2016 23:57 UTC) ==

Improvements:

  0%  installer size summary windows2012-64 pgo       57460995.5 -> 57263786.42
  0%  installer size summary windows2012-32 opt       53321609.33 -> 53138599.08
  0%  installer size summary windowsxp opt            53381928.25 -> 53200213.17
  0%  installer size summary windows2012-64 opt       57342213.67 -> 57155374.58
  0%  installer size summary windows2012-32 pgo       54479379.42 -> 54305596.92
  0%  installer size summary windows8-64 opt          57398811.58 -> 57213538.92
  0%  installer size summary windows8-64 pgo          57570554.25 -> 57413123.67
  0%  installer size summary windowsxp pgo            54598277.92 -> 54453335.75
  0%  installer size summary windows2012-32 debug     66862889.92 -> 66685301.83
  0%  installer size summary windowsxp debug          66942286.83 -> 66764153.92

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=4517
(Assignee)

Comment 15

4 months ago
Hello i would like to patch the  similar ones in this dependency tree bug 1316187 (https://bugzilla.mozilla.org/showdependencytree.cgi?id=1316187&hide_resolved=1), but when i try to remove and then build firefox i get an error saying the same files are missing , have the references really been commented out ?
(Reporter)

Comment 16

4 months ago
(In reply to pass2pawan from comment #15)
> Hello i would like to patch the  similar ones in this dependency tree bug
> 1316187
> (https://bugzilla.mozilla.org/showdependencytree.
> cgi?id=1316187&hide_resolved=1), but when i try to remove and then build
> firefox i get an error saying the same files are missing , have the
> references really been commented out ?

I replied in bug 1320126.
You need to log in before you can comment on or make changes to this bug.