1320019 - Remove Unity plugin quirk compatibility

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Chris Peterson [:cpeterson]]

This patch removes eSpecialType_Unity, QUIRK_UNITY_FIXUP_MOUSE_CAPTURE, and the corresponding Windows message hooks added in bug 1151318.

Comment 2

[Chris Peterson [:cpeterson]]

Comment on attachment 8813994 [details] [diff] [review]
remove-Unity-quirks.patch

This patch removes eSpecialType_Unity, QUIRK_UNITY_FIXUP_MOUSE_CAPTURE, and the corresponding Windows message hooks added in bug 1151318.

Because we dropped support for plugins other than Flash in 52, we can remove workarounds for other plugins like Unity.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8813994 [details] [diff] [review]
remove-Unity-quirks.patch

Review of attachment 8813994 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/ipc/PluginInstanceChild.cpp
@@ +219,2 @@
>      // In the event that we registered for audio device changes, stop.
> +    PluginModuleChild* chromeInstance = PluginModuleChild::GetChrome();

For some reason splinter is showing that this line and the line below it changed. I'm not sure why. Maybe check to make sure that there isn't new whitespace or something?

Comment 4

[Chris Peterson [:cpeterson]]

(In reply to Aaron Klotz [:aklotz] from comment #3)
> For some reason splinter is showing that this line and the line below it
> changed. I'm not sure why. Maybe check to make sure that there isn't new
> whitespace or something?

Those lines had Windows CR line endings. You can see the ␍ control characters added here:

http://searchfox.org/mozilla-central/diff/17683f933ccfbcf59417bbbc72f1372114d41adc/dom/plugins/ipc/PluginInstanceChild.cpp#228-229

Comment 5

[Guilherme Lima]

The patch landed with the number from the duplicate bug.