1320108 - [DateTimePicker] Delete button is not visible in High contrast mode

Status: RESOLVED WORKSFORME

(Core :: Layout: Form Controls, defect, P3)

Description

[roxleitan]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20161123030208

[Affected versions]:
Nightly 53.0a1

[Affected platforms]:
All platforms: Windows 10 x 64, Windows 7, Mac OS X 10.11

[Steps to reproduce]:
1.Activate High Contrast mode
2.Launch Nightly 53.0a1 with a new profile
3.Set "dom.forms.datetime" pref to True in about:config
4.In the URL bar enter "data:text/html, <input type="time">"
5.Set time value

[Expected result]:
Time value should be set and Delete button should be visible

[Actual result]:
Delete button is invisible, but is functional

Comment 1

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

SV team suggested this should be fix.
NI myself to triage with devs.

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Scott, do you have solution in mind for this?

Comment 3

[Scott Wu [:scottwu]]

I'll take a look and ask someone who has dealt with high contrast mode.

Comment 4

[Scott Wu [:scottwu]]

Attachment: Bug 1320108 - Support high-contrast code by using image instead of background for reset button

Review commit: https://reviewboard.mozilla.org/r/174240/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/174240/

Comment 5

[Scott Wu [:scottwu]]

Comment on attachment 8902630 [details]
Bug 1320108 - Support high-contrast code by using image instead of background for reset button

High contrast mode ignores all background images, so one workaround is to use `<img>` instead. Could you think of any issue that we might encounter if we do this?

Comment 6

[Scott Wu [:scottwu]]

(In reply to [e-mail] from comment #0)
> [Affected platforms]:
> All platforms: Windows 10 x 64, Windows 7, Mac OS X 10.11

Is MacOS affected? I don't know there's a High Contrast Mode on Mac. I only see the `Increase Contrast` option under `Accessibility`, but it doesn't affect our UIs.

Comment 7

[roxleitan]

Hi Scott,

Tested on latest Nightly 57.0a1 (Build ID:20170830220349), on Mac OS X 10.12 and with "Increased Contrast" checked and Maximum Display contrast, delete button is not visible. 
If Display contrast is not maximum, but higher than normal value, the button is visible.

Comment 8

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8902630 [details]
Bug 1320108 - Support high-contrast code by using image instead of background for reset button

This looks okay to me and everything works as expected with this patch.

However, as we tested, this fixes the case on Windows high contrast mode, but does not fix macOS with "Increased Contrast" with maximum value. macOS "Invert Colors" works fine though.

Note that the reset button is also not visible on Chrome with "Increased Contrast" with maximum value.

Comment 9

[Scott Wu [:scottwu]]

It seems to me turning display contrast to maximum on MacOS is quite extreme. I wonder if there is any case in our UI where special treatment is done to pass this scenario?

Wesley, do you think there a need to support this?

Comment 10

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

From my view that's a corner case we'd rather not spend efforts on.
When "increased contrast" to the maximum, even the essential back, forward, refresh, home buttons becomes invisible.

Comment 11

[Paul Yang [:pyang] (away)]

Not saying this isn't an issue, but following str I can't even read osx's system menu properly.
Keep it as known issue but not harmful.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.

Comment 14

[Anna Yeddi [:ayeddi]]

The Reset button was replaced with a Calendar button as a part of the accessibility improvement work in the bug 1676068 and the HCM support is added to the Calendar button (the datepicker itself is to update the HCM styling per the bug 1797669).

Unless the Reset button would be added to the date/datetime inputs and/or to the time inputs (per the bug 1801911), I think we can close this bug as works for me as the button is no longer present in the UI.