|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0 Build ID: 20161123030208 [Affected versions]: Nightly 53.0a1 [Affected platforms]: All platforms: Windows 10 x 64, Windows 7, Mac OS X 10.11 [Steps to reproduce]: 1.Activate High Contrast mode 2.Launch Nightly 53.0a1 with a new profile 3.Set "dom.forms.datetime" pref to True in about:config 4.In the URL bar enter "data:text/html, <input type="time">" 5.Set time value [Expected result]: Time value should be set and Delete button should be visible [Actual result]: Delete button is invisible, but is functional
Component: XUL Widgets → Layout: Form Controls
Product: Toolkit → Core
SV team suggested this should be fix. NI myself to triage with devs.
Scott, do you have solution in mind for this?
Flags: needinfo?(whuang) → needinfo?(scwwu)
I'll take a look and ask someone who has dealt with high contrast mode.
Assignee: nobody → scwwu
Comment on attachment 8902630 [details] Bug 1320108 - Support high-contrast code by using image instead of background for reset button High contrast mode ignores all background images, so one workaround is to use `<img>` instead. Could you think of any issue that we might encounter if we do this?
(In reply to email@example.com from comment #0) > [Affected platforms]: > All platforms: Windows 10 x 64, Windows 7, Mac OS X 10.11 Is MacOS affected? I don't know there's a High Contrast Mode on Mac. I only see the `Increase Contrast` option under `Accessibility`, but it doesn't affect our UIs.
Hi Scott, Tested on latest Nightly 57.0a1 (Build ID:20170830220349), on Mac OS X 10.12 and with "Increased Contrast" checked and Maximum Display contrast, delete button is not visible. If Display contrast is not maximum, but higher than normal value, the button is visible.
Comment on attachment 8902630 [details] Bug 1320108 - Support high-contrast code by using image instead of background for reset button This looks okay to me and everything works as expected with this patch. However, as we tested, this fixes the case on Windows high contrast mode, but does not fix macOS with "Increased Contrast" with maximum value. macOS "Invert Colors" works fine though. Note that the reset button is also not visible on Chrome with "Increased Contrast" with maximum value.
It seems to me turning display contrast to maximum on MacOS is quite extreme. I wonder if there is any case in our UI where special treatment is done to pass this scenario? Wesley, do you think there a need to support this?
From my view that's a corner case we'd rather not spend efforts on. When "increased contrast" to the maximum, even the essential back, forward, refresh, home buttons becomes invisible.
Not saying this isn't an issue, but following str I can't even read osx's system menu properly. Keep it as known issue but not harmful.
You need to log in before you can comment on or make changes to this bug.