Closed Bug 1320186 Opened 3 years ago Closed 3 years ago

Don't sanitize storage values more than once

Categories

(WebExtensions :: General, defect, P1)

51 Branch
defect

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed
Blocking Flags:
webextensions +

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 1 open bug)

Details

(Whiteboard: storage, triaged)

Attachments

(1 file)

Currently, we're sanitizing storage values both in ext-c-storage.js's get and set methods, and in ExtensionStorage.jsm's set method. There's really no need to do this twice, and for particularly large or complex objects, we take a non-trivial performance hit for it (e.g., bug 1319474)
Assignee: nobody → kmaglione+bmo
Priority: -- → P1
Whiteboard: storage, triaged
webextensions: --- → ?
webextensions: ? → +
Blocks: webext-perf
See Also: → 1277612
Depends on: 1369655
Blocks: 1369655
No longer depends on: 1369655
Blocks: 1370752
Comment on attachment 8875090 [details]
Bug 1320186: Don't sanitize storage values more than once.

https://reviewboard.mozilla.org/r/146458/#review150474
Attachment #8875090 - Flags: review?(aswan) → review+
https://hg.mozilla.org/mozilla-central/rev/f79cc01cb73f
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.