1320316 - [findbugs] [Bx] [RV] [NP] Warnings in test code

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

When running findbugs over all code then it finds some "high priority" issues in test code too (We want to run it over all code to avoid false positives like described in bug 1320300).

> NP:
> Bug type NP_NULL_ON_SOME_PATH (click for details)
> In class org.mozilla.gecko.tests.DatabaseHelper
> In method org.mozilla.gecko.tests.DatabaseHelper.buildUri(DatabaseHelper$BrowserDataType)
> Value loaded from uri
> Dereferenced at DatabaseHelper.java:[line 47]
> Null value at DatabaseHelper.java:[line 41]
> Known null at DatabaseHelper.java:[line 45]

> NP:
> Bug type NP_NULL_PARAM_DEREF_NONVIRTUAL (click for details)
> In class org.mozilla.gecko.tests.testHomeListsProvider
> In method org.mozilla.gecko.tests.testHomeListsProvider.setUp()
> Called method org.mozilla.gecko.tests.ContentProviderTest.setUp(Callable, String,  String)
> At testHomeListsProvider.java:[line 39]
> Argument 1 is definitely null but must not be null

> Bx
> Bug type DM_BOXED_PRIMITIVE_TOSTRING (click for details)
> In class org.mozilla.gecko.sync.net.test.TestLiveHawkAuth
> In method org.mozilla.gecko.sync.net.test.TestLiveHawkAuth.testHawkUsage()
> Called method Integer.toString()
> Should call Integer.toString(int) instead
> At TestLiveHawkAuth.java:[line 70]

> RV
> Bug type RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT (click for details)
> In class org.mozilla.gecko.dlc.TestDownloadAction
> In method org.mozilla.gecko.dlc.TestDownloadAction.mockFileWithUsableSpace(boolean, long, long)
> Called method java.io.File.getParentFile()
> At TestDownloadAction.java:[line 594]

Comment 1

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.