Panels reappear when parent window miniaturized

VERIFIED FIXED in Firefox 53

Status

()

P3
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: enndeakin, Assigned: enndeakin)

Tracking

unspecified
mozilla53
All
macOS
Points:
---

Firefox Tracking Flags

(firefox53 verified)

Details

(Whiteboard: tpi:+)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 years ago
Posted patch minimizepopup-mac (obsolete) — Splinter Review
Create a window that opens a noautohide panel:

<button label="Open" type="panel">
  <panel noautohide="true">
    <label value="OK"/>
  </panel>
</button>

Steps:
 1. Open the panel.
 2. Miniaturize the window.

The panel gets reshown even after it was miniaturized. Similarly, hiding the window with Command+H will keep the popup onscreen.

Windows and Linux hide the panel when the window is minimized. Sometimes it does stay hidden on Mac, but usually it does not.
Attachment #8814445 - Flags: review?(mstange)
Comment on attachment 8814445 [details] [diff] [review]
minimizepopup-mac

Hmm, I'm not convinced that this is doing what you think it's doing. This only stops the content view inside the popup window from being visible within the window. But if we get to that place in the code, then the window itself will still be shown (it might just be empty). I think you need to move the check to a different place in this function.
Attachment #8814445 - Flags: review?(mstange)
Priority: -- → P3
Whiteboard: tpi:+
(Assignee)

Comment 2

2 years ago
I'm not sure I understand the comment above, did you mean just move the check outside the mPopupContentView check? I also added a nativeParentWindow is not null clause.
Attachment #8814445 - Attachment is obsolete: true
Attachment #8820004 - Flags: review?(mstange)
Comment on attachment 8820004 [details] [diff] [review]
Don't show popup when parent minimized

Review of attachment 8820004 [details] [diff] [review]:
-----------------------------------------------------------------

Oops, not sure what I was thinking when I wrote that comment. Your last patch was correct, too. But I prefer this one.
Attachment #8820004 - Flags: review?(mstange) → review+
(Assignee)

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/91aae4f355330df6dcd68319ef831e5ef0fd8153
Bug 1320341, don't show a panel when the parent window is miniaturized or hidden, r=mstange

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/91aae4f35533
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Verified as fixed on latest Aurora 53.0a2 and latest Nightly 54.0a1 on Mac OS X 10.10. Tested the scenario from bug 1325076.
Status: RESOLVED → VERIFIED
status-firefox53: fixed → verified
You need to log in before you can comment on or make changes to this bug.