Last Comment Bug 1320341 - Panels reappear when parent window miniaturized
: Panels reappear when parent window miniaturized
Product: Core
Classification: Components
Component: Widget: Cocoa (show other bugs)
: unspecified
: All Mac OS X
P3 normal (vote)
: mozilla53
Assigned To: Neil Deakin
: Markus Stange [:mstange] (away until Feb 22)
Depends on:
  Show dependency treegraph
Reported: 2016-11-25 08:00 PST by Neil Deakin
Modified: 2016-12-23 07:25 PST (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

minimizepopup-mac (1.13 KB, patch)
2016-11-25 08:00 PST, Neil Deakin
no flags Details | Diff | Splinter Review
Don't show popup when parent minimized (1.20 KB, patch)
2016-12-19 11:31 PST, Neil Deakin
mstange: review+
Details | Diff | Splinter Review

Description User image Neil Deakin 2016-11-25 08:00:46 PST
Created attachment 8814445 [details] [diff] [review]

Create a window that opens a noautohide panel:

<button label="Open" type="panel">
  <panel noautohide="true">
    <label value="OK"/>

 1. Open the panel.
 2. Miniaturize the window.

The panel gets reshown even after it was miniaturized. Similarly, hiding the window with Command+H will keep the popup onscreen.

Windows and Linux hide the panel when the window is minimized. Sometimes it does stay hidden on Mac, but usually it does not.
Comment 1 User image Markus Stange [:mstange] (away until Feb 22) 2016-11-29 18:05:46 PST
Comment on attachment 8814445 [details] [diff] [review]

Hmm, I'm not convinced that this is doing what you think it's doing. This only stops the content view inside the popup window from being visible within the window. But if we get to that place in the code, then the window itself will still be shown (it might just be empty). I think you need to move the check to a different place in this function.
Comment 2 User image Neil Deakin 2016-12-19 11:31:04 PST
Created attachment 8820004 [details] [diff] [review]
Don't show popup when parent minimized

I'm not sure I understand the comment above, did you mean just move the check outside the mPopupContentView check? I also added a nativeParentWindow is not null clause.
Comment 3 User image Markus Stange [:mstange] (away until Feb 22) 2016-12-21 05:24:41 PST
Comment on attachment 8820004 [details] [diff] [review]
Don't show popup when parent minimized

Review of attachment 8820004 [details] [diff] [review]:

Oops, not sure what I was thinking when I wrote that comment. Your last patch was correct, too. But I prefer this one.
Comment 4 User image Neil Deakin 2016-12-22 08:07:27 PST
Bug 1320341, don't show a panel when the parent window is miniaturized or hidden, r=mstange
Comment 5 User image Wes Kocher (:KWierso) 2016-12-22 18:41:24 PST

Note You need to log in before you can comment on or make changes to this bug.