Closed Bug 1320376 Opened 5 years ago Closed 5 years ago

"nightly" context menu stops working when removing containers

Categories

(Core :: DOM: Security, defect)

53 Branch
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1319911
Tracking Status
firefox53 --- fixed

People

(Reporter: kjozwiak, Unassigned)

Details

(Keywords: regression)

When removing containers via about:preferences#containers, the "Nightly" context menu stops working when using macOS. When you open a new window, the context menu will return.

Video of the issue occurring:
* https://youtu.be/j2Rl8GCOFm8

STR:

* launch the latest m-c
* visit about:preferences#containers in a regular tab
* open a new container (doesn't matter which one)
* go back into the tab with about:preferences#container opened
* remove the tab that's currently opened
* once the container has been removed, click on "Nightly" to get the context menu

You'll notice that the context menu won't appear when click in Nightly. If you open a new window, it will return.
Has STR: --- → yes
Is this a regression, and if so are we sure it's from bug 1316740? You didn't add the keywords for this, and I am suspicious this was caused by bug 1317317 instead, which was uplifted to aurora (where containers is turned off by default, but which we might end up using for experiments/funnelcakes with it later), so we should be sure what caused this and which builds are affected.
Flags: needinfo?(kjozwiak)
I couldn't reproduce this with the latest m-c so I went through mozregression using the "--find-fix" flag. Bug#1292527 caused the regression which was than fixed by bug#1319911. This only affected the m-c (fx53) channel.

26:37.60 INFO: First good revision: 49228a69b071bc200360aa43845b42b996759479
26:37.60 INFO: Last bad revision: 900960e68528c73afb6cfb3d97400bb3311386cf
26:37.60 INFO: Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=900960e68528c73afb6cfb3d97400bb3311386cf&tochange=49228a69b071bc200360aa43845b42b996759479

26:38.19 INFO: Looks like the following bug has the changes which introduced the fix:
https://bugzilla.mozilla.org/show_bug.cgi?id=1319911
No longer blocks: ContextualIdentity, 1316740
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(kjozwiak)
Keywords: regression
Resolution: --- → DUPLICATE
Whiteboard: [userContextId][domsecurity-backlog]
Duplicate of bug: 1319911
You need to log in before you can comment on or make changes to this bug.