1320538 - There is no confirmation dialog after completing bookmark importing/exporting task and when it's still going on during browser shutdown

Status: NEW

(Firefox :: Bookmarks & History, defect, P3)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/message/reply/question/etc.)]

STR:
1. Go to Library
2. Import bookmarks either from json or html file
3. There is no confirmation dialog after completing bookmark exporting task
like how many bookmarks were exported or just simple like "bookmark exporting is complete" and press "OK" etc.

only CPU usage is the hint when in ends...

This is causing data loss when you close Firefox and it's still working or bookmark exporting task.

Comment 1

[Marco Bonardo [:mak]]

which kind of dataloss? Failing to store the json would not be a dataloss, would just be a missing export of a file that regardless we try to create once a day or so.
At a maximum we could maybe block browser closing with a message, but I suspect it would be super annoying...

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/message/reply/question/etc.)]

Attachment: screenshot.png

(In reply to Marco Bonardo [::mak] from comment #1)
> which kind of dataloss? Failing to store the json would not be a dataloss,
> would just be a missing export of a file that regardless we try to create
> once a day or so.

Dataloss per not complete and identical backup.
Simple story, I want to backup bookmarks, but without additional favicons, so I'm choosing JSON method, as it's still bugged and don't have this feature implanted. After some time I'm closing Firefox because I think it ended already. Unfortunately there is no any warning that exporting is still going on, so backup is not complete and identical. When I will be exporting this broken file on other PC or restoring backup, only thing I will be seeing is my frustration on Firefox, because of not complete and identical backup it made and no information that is still going on when I was closing it.



(In reply to Marco Bonardo [::mak] from comment #1)
> At a maximum we could maybe block browser closing with a message, but I
> suspect it would be super annoying...

If it will be similar as "file downloading is still ongoing",
it will be still better to see message like
> "Cancel Exporting Bookmarks
>> If you exit now, exporting bookmarks will be canceled. Are you sure you want to exit?"
than loosing data.

Comment 3

[Marco Bonardo [:mak]]

we should probably add an async shutdown blocker.

Comment 4

[Julien Cristau [:jcristau]]

Mass wontfix for bugs affecting firefox 52.

Comment 6

[Mark Banner (:standard8)]

The shutdown blocker is probably not sufficient by itself, as operations which continue for more than a minute after shutdown would still be cut-off.

Hence we probably need some sort of UX here, which may make this a dupe or more closely related to bug 1432738.