1320891 - Make some webrtc tests build with gcc 7.0 and --enable-warnings-as-errors

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

First, in media/webrtc/signaling/test/mediaconduit_unittests.cpp, gcc 7.0 is complaining about the following:
 error: suggest explicit braces to avoid ambiguous 'else' [-Werror=dangling-else]
I guess this is caused by the ASSERT_NE define. As it doesn't hurt, we can add {} to silent it.

Second, similar to bug 1320878, an expression in an assert is always returning true.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1320891 - Make some webrtc tests build with gcc 7.0 and --enable-warnings-as-errors

Review commit: https://reviewboard.mozilla.org/r/96232/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96232/

Comment 2

[Byron Campen [:bwc]]

Comment on attachment 8815203 [details]
Bug 1320891 - Make some webrtc tests build with gcc 7.0 and --enable-warnings-as-errors

https://reviewboard.mozilla.org/r/96232/#review96468

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/918309d4aea0
Make some webrtc tests build with gcc 7.0 and --enable-warnings-as-errors r=bwc

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/918309d4aea0