1320976 - `moz-phab` script should check reviewers being available before offering to publish from the commandline, and instead tell you and offer to remove unavailable reviewers and publish anyway

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect)

Description

[:Gijs (away/busy until Mar 10)]

Sample current output:

gijs-mbp:firefox-unified gkruitbosch$ hg push -r . review
pushing to ssh://reviewboard-hg.mozilla.org/autoreview
searching for appropriate review repository
redirecting push to ssh://reviewboard-hg.mozilla.org/gecko
searching for changes
remote: adding changesets                                                                                                                                                                                             
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 3 changes to 3 files (+1 heads)
remote: recorded push in pushlog
submitting 1 changesets for review

changeset:  359631:ca89d4753647
summary:    Bug 1320124 - don't allow privileged loads inside unprivileged loads, r?bz
review:     https://reviewboard.mozilla.org/r/96282 (draft)

review id:  bz://1320124/Gijs
review url: https://reviewboard.mozilla.org/r/96280 (draft)

publish these review requests now (Yn)?  y
error publishing review request 96280: Error publishing: Bugzilla error: Boris Zbarsky [:bz] (still a bit busy) <[e-mail]> is not currently accepting 'review' requests. (HTTP 500, API Error 225)
(review requests not published; visit review url to attempt publishing there)


Instead, it should be asking bugzilla about reviewers when I push, and (in red, like the error) say something like:

WARNING: some reviewers (namely: <list of reviewers>) are not currently accepting review requests.

Would you like to remove those reviewers and publish anyway? (yN)

Comment 1

[:glob ✱]

i like this suggestion.

we'd need bmo to expose the 'blocking requests' bit over their api (filed bug 1320977).

implementation-wise it's probably best to parse the commit desc client-side for reviewers, find and check the status of all of them with a single bmo api call - ensuring we display "checking reviewers.." or similar to let the user know something's going on.

Comment 2

[Mark Côté [:mcote]]

We've been discussing this with Phacility, although eventually we may want to do something more complicated like checking review queues and such.

Comment 4

[:glob ✱]

from bug 1481535

* valid as per phabricator
* call `arc call-conduit {blah}`
* maybe checking their status in bugzilla?  [bug 1320976]