Closed
Bug 1320976
Opened 8 years ago
Closed 5 years ago
`moz-phab` script should check reviewers being available before offering to publish from the commandline, and instead tell you and offer to remove unavailable reviewers and publish anyway
Categories
(Conduit :: moz-phab, defect)
Conduit
moz-phab
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Gijs, Unassigned)
References
Details
(Keywords: conduit-backlog, conduit-story, conduit-triaged)
Sample current output: gijs-mbp:firefox-unified gkruitbosch$ hg push -r . review pushing to ssh://reviewboard-hg.mozilla.org/autoreview searching for appropriate review repository redirecting push to ssh://reviewboard-hg.mozilla.org/gecko searching for changes remote: adding changesets remote: adding manifests remote: adding file changes remote: added 1 changesets with 3 changes to 3 files (+1 heads) remote: recorded push in pushlog submitting 1 changesets for review changeset: 359631:ca89d4753647 summary: Bug 1320124 - don't allow privileged loads inside unprivileged loads, r?bz review: https://reviewboard.mozilla.org/r/96282 (draft) review id: bz://1320124/Gijs review url: https://reviewboard.mozilla.org/r/96280 (draft) publish these review requests now (Yn)? y error publishing review request 96280: Error publishing: Bugzilla error: Boris Zbarsky [:bz] (still a bit busy) <bzbarsky@mit.edu> is not currently accepting 'review' requests. (HTTP 500, API Error 225) (review requests not published; visit review url to attempt publishing there) Instead, it should be asking bugzilla about reviewers when I push, and (in red, like the error) say something like: WARNING: some reviewers (namely: <list of reviewers>) are not currently accepting review requests. Would you like to remove those reviewers and publish anyway? (yN)
i like this suggestion. we'd need bmo to expose the 'blocking requests' bit over their api (filed bug 1320977). implementation-wise it's probably best to parse the commit desc client-side for reviewers, find and check the status of all of them with a single bmo api call - ensuring we display "checking reviewers.." or similar to let the user know something's going on.
Component: Integration: Mercurial → General
Product: MozReview → Conduit
Summary: Reviewboard should check reviewers being available before offering to publish from the commandline, and instead tell you and offer to remove unavailable reviewers and publish anyway → `review` script should check reviewers being available before offering to publish from the commandline, and instead tell you and offer to remove unavailable reviewers and publish anyway
Updated•6 years ago
|
Component: General → Review Wrapper
Keywords: conduit-story,
conduit-triaged
Summary: `review` script should check reviewers being available before offering to publish from the commandline, and instead tell you and offer to remove unavailable reviewers and publish anyway → `moz-phab` script should check reviewers being available before offering to publish from the commandline, and instead tell you and offer to remove unavailable reviewers and publish anyway
Comment 2•6 years ago
|
||
We've been discussing this with Phacility, although eventually we may want to do something more complicated like checking review queues and such.
Keywords: conduit-story
Whiteboard: [phabricator-backlog]
Keywords: conduit-story
from bug 1481535 * valid as per phabricator * call `arc call-conduit {blah}` * maybe checking their status in bugzilla? [bug 1320976]
Updated•5 years ago
|
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Keywords: conduit-backlog
Whiteboard: [phabricator-backlog]
You need to log in
before you can comment on or make changes to this bug.
Description
•