1482216 - Do not require a reviewer to submit with moz-phab

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect)

Description

[Tom Ritter [:tjr]]

I often want to submit patches to bugs as a checkpoint without a reviewer. moz-phab currently requires a reviewer.

Comment 1

[Dave Townsend [:mossop]]

This is a blocker for me using this tool.

Comment 2

[Tom Ritter [:tjr]]

(In reply to Dave Townsend [:mossop] from comment #1)
> This is a blocker for me using this tool.

Feel free to mark me as a reviewer ('tjr') and I will ignore anything I get from you.  That's what I ended up doing with someone.

Comment 3

[:glob ✱]

we should probably change the 'no reviewers' error to a warning which is displayed prior to the submission confirmation prompt (if any of the commits are missing reviewers).

perhaps also the commit description in the stack summary output should have a red "no reviewer" in that case.

Comment 4

[Piotr Zalewa [:zalun]]

Attachment: review: Do not require a reviewer

If user will not specify a reviewer a warning is displayed.

Comment 5

[:glob ✱]

Comment on attachment 9004818 [details]
review: Do not require a reviewer

Byron Jones ‹:glob› 🎈 has approved the revision.

Comment 6

[:glob ✱]

fixed and released in 1.2