Closed Bug 1321075 Opened 3 years ago Closed 3 years ago

Avoid calling Factory::CreateDrawTargetForData when we can guarantee failure

Categories

(Core :: Graphics, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: milan, Assigned: milan)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

We can check with Factory::DoesBackendSupportDataDrawtarget before making a call that asserts.
Assignee: nobody → milan
Priority: -- → P3
See Also: → 946501
Whiteboard: [gfx-noted]
This should clear up the "Invalid draw target type specified" asserts.
Comment on attachment 8815443 [details]
Bug 1321075: Check if the backend is friendly to data draw target creation before attempting to make it.

https://reviewboard.mozilla.org/r/96346/#review98100
Attachment #8815443 - Flags: review?(bas) → review+
Pushed by msreckovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/57cb50f186b4
Check if the backend is friendly to data draw target creation before attempting to make it. r=bas
https://hg.mozilla.org/mozilla-central/rev/57cb50f186b4
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.