Closed
Bug 1321166
Opened 7 years ago
Closed 7 years ago
Move DetailsFrame into mozilla namespace
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Currently, DetailsFrame is the only frame class under layout/generic living in global namespace yet without "ns" prefix. Better to move DetailsFrame into mozilla namespace.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
I've compiled my patch on top of bug 1321387, and replaced UNIFIED_SOURCES with SOURCES locally in layout/generic/moz.build. No new unified build bustage occurs.
Assignee: nobody → tlin
status-firefox53:
affected → ---
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8816008 [details] Bug 1321166 - Wrap DetailsFrame's definition and implementation in mozilla namespace. https://reviewboard.mozilla.org/r/96772/#review97036 Please add "namespace mozilla {...}" to the DetailsFrame.cpp file as well (from the first method, the constructor[1], to the end of the file). (It's technically not necessary for compilation -- the "using namespace mozilla" makes it Just Work -- but it's what we do elsewhere, and it's more explicit.) r=me with that added. [1] https://dxr.mozilla.org/mozilla-central/rev/741a720c98cdb92c229376be0badbf036f653bff/layout/generic/DetailsFrame.cpp#31
Attachment #8816008 -
Flags: review?(dholbert) → review+
Comment hidden (mozreview-request) |
Pushed by tlin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e36b4963793f Wrap DetailsFrame's definition and implementation in mozilla namespace. r=dholbert
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e36b4963793f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•