1321206 - stylo: Assertion failure for serializing calc value of line-height

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

Attachment: testcase

This is found when running test_value_computation.html.

The test case has been attached. It seems to be a Servo issue.

Stack backtrace:
   0:     0x7ff9a27b3e64 - <usize as std::sys::IsZero>::is_zero::h387aecc62cc0d6fc
   1:     0x7ff9a27af303 - std::panicking::Location::line::h9c748f2b719dd34c
   2:     0x7ff9a27afffd - std::panicking::rust_panic_with_hook::hc303199e04562edf
   3:     0x7ff9a26d701d - std::panicking::begin_panic<&str>
                        at C:\bot\slave\stable-dist-rustc-win-msvc-64\build\src\libstd\panicking.rs:413
   4:     0x7ff9a2321954 - style::values::specified::length::{{impl}}::to_css<nsstring_vendor::nsAString>
                        at c:\mozilla-source\stylo\obj-firefox-stylo\toolkit\library\rust\<std macros>:3
   5:     0x7ff9a231aa1a - style::values::specified::length::{{impl}}::to_css<nsstring_vendor::nsAString>
                        at C:\mozilla-source\stylo\servo\components\style\values\specified\length.rs:789
   6:     0x7ff9a2322b75 - style::properties::longhands::line_height::{{impl}}::to_css<nsstring_vendor::nsAString>
                        at c:\mozilla-source\stylo\obj-firefox-stylo\toolkit\library\rust\x86_64-pc-windows-msvc\debug\build\style-3719a002503bc45f\out\properties.rs:21268
   7:     0x7ff9a24dcde3 - style::properties::declaration_block::PropertyDeclarationBlock::property_value_to_css<nsstring_vendor::nsAString>
                        at C:\mozilla-source\stylo\servo\components\style\properties\declaration_block.rs:106

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: testcase

Actually it is even simplier. If the calc only has numbers, this crash would happen. It is because CalcLengthOrPercentage::parse can recognize numbers, but the struct itself doesn't have field for numbers, so calc only contains numbers can be parsed successfully, but the result would be empty.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

https://github.com/servo/servo/pull/14421