Bug 1321197 (stylo-style-mochitest)

[meta] stylo: Have stylo pass all style system mochitests

RESOLVED FIXED

Status

defect
P5
normal
RESOLVED FIXED
3 years ago
11 months ago

People

(Reporter: xidorn, Assigned: xidorn)

Tracking

(Depends on 1 bug, Blocks 1 bug, {meta})

Firefox Tracking Flags

(Not tracked)

Details

()

I'm going to use this bug to track issues blocking running style system tests with stylo.

I think we should do the following:
1. fix crash bugs found from running the tests
2. create a new test task which runs a subset of style system tests on ci
3. fix other bugs identified by the tests
Depends on: 1321206
Depends on: 1324627
Depends on: 1323654
Depends on: 1324632
Depends on: 1324988
Depends on: 1323655
Depends on: 1290224
Depends on: 1323665
Depends on: 1323715
Depends on: 1328499
Depends on: 1328503
Depends on: 1328505
Depends on: 1328507
Depends on: 1328511
Depends on: 1323678
Depends on: 1292283
Depends on: 1328512
Depends on: 1328513
Depends on: 1329533
Assignee: nobody → xidorn+moz
Blocks: stylo-nightly
No longer blocks: stylo
Priority: -- → P1
Depends on: 1289935
Duplicate of this bug: 1289935
Depends on: 1330503
Depends on: 1330824
Depends on: 1330825
Depends on: 1330874
Depends on: 1330885
Depends on: 1331291
Depends on: 1331294
Depends on: 1331301
Depends on: 1310886
Depends on: 1331516
Depends on: 1331529
Depends on: 1290237
Depends on: 1331543
Depends on: 1331903
Depends on: 1330172
Depends on: 1332969
Alias: stylo-style-mochitest
Depends on: 1296477
Depends on: 1335252
Depends on: 1334982
Depends on: 1335261
Depends on: 1335987
Depends on: 1335990
Depends on: 1234357
Depends on: 1336863
Depends on: 1336891
Filed a Servo side meta bug for this.
Depends on: 1337068
Depends on: 1337248
No longer depends on: 1337248
Summary: [meta] stylo: Run style system mochitests on stylo → [meta] stylo: Have style system mochitests green with stylo
Depends on: 1337599
No longer depends on: 1328507
No longer depends on: 1328511
No longer depends on: 1290224
No longer depends on: 1328505
No longer depends on: 1328499
No longer depends on: 1323665
No longer depends on: 1292283
Depends on: 1337611
Depends on: 1337612
Depends on: 1324704
Depends on: 1324647
Depends on: 1337615
No longer depends on: 1337611
No longer depends on: 1337612
Summary: [meta] stylo: Have style system mochitests green with stylo → [meta] stylo: Have stylo pass all style system mochitests
Depends on: 1337655
Depends on: 1337674
Depends on: 1338425
Now that this job is running on autoland / mc, what do you think about temporarily disabling test_align_justify_computed_values.html and test_acid3_test46.html so that we can keep it green?
Flags: needinfo?(xidorn+moz)
test_align_justify_computed_values.html and test_acid3_test46.html are not the only mochitests currently fail. There are tons of tests are still failing (see https://gist.github.com/upsuper/082268f59e6f267d5a466c2cbe698e58). Only them showing up in the panel is just because they are the first two tests run in the task and failures from them have already run out of space of that panel.

In addition to failures, there are also many non-fatal assertions (see bug 1337615).

So making that task green isn't that trivial. We may need to disable a wide range of mochitests to make it green (not sure how many, but we would lose the biggest tests including test_{inherit,initial,value}_{storage,computation}.html).

I've filed bug 1337674 to figure out the best path to green the task with the known failure list. But I'm unsure about what is the most helpful way.
Flags: needinfo?(xidorn+moz)
Depends on: 1340683
Depends on: 1341195
No longer depends on: 1328503
Depends on: 1343452
Priority: P1 → P5
Depends on: 1347381
Depends on: 1347398
Depends on: 1347409
Depends on: 1347412
Depends on: 1331530
No longer depends on: 1338425
Depends on: 1347821
Depends on: 1348022
Depends on: 1348030
Depends on: 1348165
Depends on: 1348173
Depends on: 1352669
Depends on: 1352968
Depends on: 1354998
Depends on: 1355001
Depends on: 1355005
Depends on: 1355014
Depends on: 1355017
Depends on: 1355345
Depends on: 1355352
Depends on: 1355356
Depends on: 1355364
Depends on: 1355366
Depends on: 1355368
Depends on: 1355388
Depends on: 1345697
Depends on: 1355394
Depends on: 1355402
Depends on: 1355408
Depends on: 1355412
Depends on: 1355683
Depends on: 1355715
Depends on: 1355716
Depends on: 1355721
Depends on: 1355724
Depends on: 1355734
Depends on: 1356072
Depends on: 1356087
Depends on: 1353191
Depends on: 1356104
Depends on: 1356174
Depends on: 1356494
Depends on: 1358330
Depends on: 1358353
Depends on: 1360488
Depends on: 1361663
Depends on: 1361938
Depends on: 1356916
Depends on: 1362914
Depends on: 1363590
Depends on: 1363596
Depends on: 1363968
Depends on: 1363971
Depends on: 1363974
Depends on: 1363984
Depends on: 1363986
Depends on: 1364009
Depends on: 1364260
Depends on: 1364273
Depends on: 1364286
Depends on: 1364289
Depends on: 1364799
Depends on: 1366157
No longer depends on: 1355683
Depends on: 1366544
No longer depends on: 1337655
Depends on: 1363349
Depends on: 1366934
Depends on: 1366956
Depends on: 1366961
Depends on: 1347270
Depends on: 1367028
Depends on: 1367274
Depends on: 1367299
Depends on: 1367306
Depends on: 1367310
Depends on: 1367312
Depends on: 1367315
Depends on: 1363292
Depends on: 1188074
No longer blocks: stylo
No longer depends on: 1234357
Depends on: 1382077
Depends on: 1382078
Depends on: 1382080
Depends on: 1382102
Depends on: 1389439
Mark fixed as a tracking bug.
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.