1321614 - Fix android_stuff task kind, now that it actually tries to fetch secrets

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Justin Wood (:Callek)]

+++ This bug was initially created as a clone of Bug #1321040 +++

Bug 131040 broke this.

https://treeherder.mozilla.org/logviewer.html#?job_id=7575262&repo=autoland#L951

Comment 1

[Justin Wood (:Callek)]

Attachment: Bug 1321614 - fix android_stuff kind to use build secrets, because it uses the same mozharness stuff as build jobs.

Review commit: https://reviewboard.mozilla.org/r/97012/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97012/

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8816224 [details]
Bug 1321614 - fix android_stuff kind to use build secrets, because it uses the same mozharness stuff as build jobs.

https://reviewboard.mozilla.org/r/97012/#review97238

::: taskcluster/taskgraph/transforms/android_stuff.py:11
(Diff revision 1)
>  """
>  
>  from __future__ import absolute_import, print_function, unicode_literals
>  
>  from taskgraph.transforms.base import TransformSequence
> +from taskgraph.transforms.job.common import SECRET_SCOPE, docker_worker_setup_secrets

You never use `docker_worker_setup_secrets`

::: taskcluster/taskgraph/transforms/android_stuff.py:48
(Diff revision 1)
>                  'mount-point': "/home/worker/workspace",
>              })
>  
> +        # Need appropriate scopes for secrets, from the 'build' section
> +        task['worker']['taskcluster-proxy'] = True
> +        for sec in ['*']:

This seems kind of silly -- either take it from a parameter, or just append '*'..

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 8816224 [details]
Bug 1321614 - fix android_stuff kind to use build secrets, because it uses the same mozharness stuff as build jobs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/97012/diff/1-2/

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8816224 [details]
Bug 1321614 - fix android_stuff kind to use build secrets, because it uses the same mozharness stuff as build jobs.

https://reviewboard.mozilla.org/r/97012/#review97242

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/402535c48034
fix android_stuff kind to use build secrets, because it uses the same mozharness stuff as build jobs. r=dustin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/6f39c69810f2
fix android_stuff kind to use build secrets, because it uses the same mozharness stuff as build jobs. r=dustin a=bustage

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Pulsebot from comment #6)
> Pushed by [e-mail]:
> https://hg.mozilla.org/mozilla-central/rev/6f39c69810f2
> fix android_stuff kind to use build secrets, because it uses the same
> mozharness stuff as build jobs. r=dustin a=bustage

Had to manually graft this to m-c and inbound because I did a merge in between when the android tests broke and when the fix landed on autoland. Next regular merge will likely comment in here again when the original patch merges around.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/402535c48034