1321040 - Set TC Secrets (like MOZ_API_KEY) on date

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Justin Wood (:Callek)]

During verification, I noticed that we are not setting most secrets for the date nightlies.

This is an issue because Date is set to L2 and m-c is set to L3. Coop's opinion is to set Date as L3 to fix it up sooner, and more-matching-of-m-c.

I'm inclined to agree and will file a dep bug on that.

Comment 1

[Justin Wood (:Callek)]

Now that dependant bugs are solved, I've set the hooks to trigger the decision task as Level 3 and kicked them off, I'll find out sooner than later if that solved this bug.

Comment 2

[Justin Wood (:Callek)]

Sooo apparantly, this wasn't enough, since its still using the default value (min scm level not met) despite:

https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/secrets.py#66

Comment 3

[Justin Wood (:Callek)]

(noteworthy, this 'using default value for' is happening even on m-c non-nightly tc Builds)

Comment 4

[Justin Wood (:Callek)]

Ah-ha https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/building/buildbase.py#559

vs https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/secrets.py#55

scm-level vs scm_level

Comment 5

[Justin Wood (:Callek)]

Attachment: Bug 1321040 - add secret scopes to tasks that need them, where they were previously absent.

Review commit: https://reviewboard.mozilla.org/r/96904/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96904/

Comment 6

[Justin Wood (:Callek)]

Already landed this on date.

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8816108 [details]
Bug 1321040 - add secret scopes to tasks that need them, where they were previously absent.

https://reviewboard.mozilla.org/r/96904/#review97122

Comment 8

[Justin Wood (:Callek)]

Comment on attachment 8816108 [details]
Bug 1321040 - add secret scopes to tasks that need them, where they were previously absent.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/96904/diff/1-2/

Comment 9

[Justin Wood (:Callek)]

Attachment: Bug 1321040 - properly reference scm level so we can use tc secrets from mozharness.

Review commit: https://reviewboard.mozilla.org/r/96906/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96906/

Comment 10

[Justin Wood (:Callek)]

Comment on attachment 8816108 [details]
Bug 1321040 - add secret scopes to tasks that need them, where they were previously absent.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/96904/diff/2-3/

Comment 11

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8816113 [details]
Bug 1321040 - properly reference scm level so we can use tc secrets from mozharness.

https://reviewboard.mozilla.org/r/96906/#review97132

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a125781c9c3
properly reference scm level so we can use tc secrets from mozharness. r=dustin
https://hg.mozilla.org/integration/autoland/rev/f8ccc2a00d62
add secret scopes to tasks that need them, where they were previously absent. r=dustin

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4a125781c9c3
https://hg.mozilla.org/mozilla-central/rev/f8ccc2a00d62