Closed Bug 1321040 Opened 3 years ago Closed 3 years ago

Set TC Secrets (like MOZ_API_KEY) on date

Categories

(Release Engineering :: General, defect)

defect
Not set

Tracking

(firefox53 fixed)

RESOLVED FIXED
Tracking Status
firefox53 --- fixed

People

(Reporter: Callek, Unassigned)

References

Details

Attachments

(2 files)

During verification, I noticed that we are not setting most secrets for the date nightlies.

This is an issue because Date is set to L2 and m-c is set to L3. Coop's opinion is to set Date as L3 to fix it up sooner, and more-matching-of-m-c.

I'm inclined to agree and will file a dep bug on that.
Depends on: 1321042
Depends on: 1321043
Now that dependant bugs are solved, I've set the hooks to trigger the decision task as Level 3 and kicked them off, I'll find out sooner than later if that solved this bug.
Sooo apparantly, this wasn't enough, since its still using the default value (min scm level not met) despite:

https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/mozharness/mozilla/secrets.py#66
(noteworthy, this 'using default value for' is happening even on m-c non-nightly tc Builds)
Already landed this on date.
Comment on attachment 8816108 [details]
Bug 1321040 - add secret scopes to tasks that need them, where they were previously absent.

https://reviewboard.mozilla.org/r/96904/#review97122
Attachment #8816108 - Flags: review?(dustin) → review+
Comment on attachment 8816113 [details]
Bug 1321040 - properly reference scm level so we can use tc secrets from mozharness.

https://reviewboard.mozilla.org/r/96906/#review97132
Attachment #8816113 - Flags: review?(dustin) → review+
Pushed by Callek@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4a125781c9c3
properly reference scm level so we can use tc secrets from mozharness. r=dustin
https://hg.mozilla.org/integration/autoland/rev/f8ccc2a00d62
add secret scopes to tasks that need them, where they were previously absent. r=dustin
Blocks: 1321614
No longer depends on: 1355131
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.