1321628 - add ice restart and rollback counts to about:webrtc

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Michael Froman [:mjf]]

It will help to see how many ICE restarts and/or rollbacks have occurred.

Comment 1

[Michael Froman [:mjf]]

Attachment: Bug 1321628 - add ice restart and rollback counts to about:webrtc.

Review commit: https://reviewboard.mozilla.org/r/97056/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97056/

Comment 2

[Nils Ohlmeier [:drno]]

Comment on attachment 8816254 [details]
Bug 1321628 - add ice restart and rollback counts to about:webrtc.

https://reviewboard.mozilla.org/r/97056/#review97428

::: dom/webidl/RTCStatsReport.webidl:166
(Diff revision 1)
> +  unsigned long                       iceRestarts;
> +  unsigned long                       iceRollbacks;

If I'm not mistaken you need a DOM reviewer here, because you are modifying a WebIDL file.
https://wiki.mozilla.org/Modules/All

::: media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.h:821
(Diff revision 1)
> +  unsigned long mIceRestartCount;
> +  unsigned long mIceRollbackCount;

Long term we probably should not pollute PCImpl with all the possible ICE stats. In this case and for now it is hopefully alright.

::: toolkit/content/aboutwebrtc/aboutWebrtc.js:681
(Diff revision 1)
> +
> +    div.appendChild(this.renderIceMetric("ice_restart_count_label",
> +                                         this._report.iceRestarts));
> +    div.appendChild(this.renderIceMetric("ice_rollback_count_label",
> +                                         this._report.iceRollbacks));
> +

If this means that these two counters appear above the ICE connection table, could you move it below the table?
My reasoning here is to keep things in the order of importance.

Comment 3

[Michael Froman [:mjf]]

Comment on attachment 8816254 [details]
Bug 1321628 - add ice restart and rollback counts to about:webrtc.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/97056/diff/1-2/

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8816254 [details]
Bug 1321628 - add ice restart and rollback counts to about:webrtc.

https://reviewboard.mozilla.org/r/97056/#review98312

ChromeOnly stuff, ok.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d807888d2831
add ice restart and rollback counts to about:webrtc. r=drno,smaug

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d807888d2831