Closed Bug 1321628 Opened 3 years ago Closed 3 years ago

add ice restart and rollback counts to about:webrtc

Categories

(Core :: WebRTC: Networking, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: mjf, Assigned: mjf)

References

Details

Attachments

(1 file)

It will help to see how many ICE restarts and/or rollbacks have occurred.
Rank: 25
Priority: -- → P2
Comment on attachment 8816254 [details]
Bug 1321628 - add ice restart and rollback counts to about:webrtc.

https://reviewboard.mozilla.org/r/97056/#review97428

::: dom/webidl/RTCStatsReport.webidl:166
(Diff revision 1)
> +  unsigned long                       iceRestarts;
> +  unsigned long                       iceRollbacks;

If I'm not mistaken you need a DOM reviewer here, because you are modifying a WebIDL file.
https://wiki.mozilla.org/Modules/All

::: media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.h:821
(Diff revision 1)
> +  unsigned long mIceRestartCount;
> +  unsigned long mIceRollbackCount;

Long term we probably should not pollute PCImpl with all the possible ICE stats. In this case and for now it is hopefully alright.

::: toolkit/content/aboutwebrtc/aboutWebrtc.js:681
(Diff revision 1)
> +
> +    div.appendChild(this.renderIceMetric("ice_restart_count_label",
> +                                         this._report.iceRestarts));
> +    div.appendChild(this.renderIceMetric("ice_rollback_count_label",
> +                                         this._report.iceRollbacks));
> +

If this means that these two counters appear above the ICE connection table, could you move it below the table?
My reasoning here is to keep things in the order of importance.
Attachment #8816254 - Flags: review?(drno) → review+
Comment on attachment 8816254 [details]
Bug 1321628 - add ice restart and rollback counts to about:webrtc.

https://reviewboard.mozilla.org/r/97056/#review98312

ChromeOnly stuff, ok.
Attachment #8816254 - Flags: review?(bugs) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d807888d2831
add ice restart and rollback counts to about:webrtc. r=drno,smaug
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d807888d2831
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Blocks: 1406434
You need to log in before you can comment on or make changes to this bug.