1406434 - webrtc.org v49 import broke ice restart and rollback counts on about:webrtc

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P2)

Description

[Michael Froman [:mjf]]

The v49 import (126348e718d0) pushed on 2016/12/29 overwrote the changes in PeerConnectionImpl.{h|cpp} for Bug 1321628.

Comment 1

[Michael Froman [:mjf]]

Attachment: Bug 1406434 - fixing ice restart and rollback counts on about:webrtc.

This is re-adding changes from Bug 1321628 that were overwritten by the
webrtc.org v49 import.

Review commit: https://reviewboard.mozilla.org/r/187308/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187308/

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 8916048 [details]
Bug 1406434 - fixing ice restart and rollback counts on about:webrtc.

https://reviewboard.mozilla.org/r/187308/#review192342

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb5a6eedfffa
fixing ice restart and rollback counts on about:webrtc. r=ng

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/cb5a6eedfffa

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Given that we've been shipping with this bug since 53, it seems like this can ride the 58 train? Feel free to set the status for 57 back to affected and nominate it for approval if you feel strongly otherwise.