Remove calls to AndroidBridge::PostTaskToUiThread from APZ

RESOLVED FIXED in Firefox 53

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: rbarker, Assigned: rbarker)

Tracking

Trunk
Firefox 53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

2 years ago
Once GeckoView support nsThread and MessageLoop in the Android UI thread, it will no longer be necessary to have code that calls AndroidBridge::PostTaskToUiThread for dispatching to the UI/Controller thread.
(Assignee)

Updated

2 years ago
Assignee: nobody → rbarker
(Assignee)

Updated

2 years ago
Depends on: 1319850
(Assignee)

Comment 1

2 years ago
Created attachment 8816273 [details] [diff] [review]
0001-Bug-1321642-Add-missing-include-guards-to-nsDeviceContextAndroid.h-16120113-1ac30dc.patch
(Assignee)

Updated

2 years ago
Attachment #8816273 - Flags: review?(nchen)
(Assignee)

Updated

2 years ago
Attachment #8816273 - Flags: review?(nchen)
(Assignee)

Comment 2

2 years ago
Comment on attachment 8816273 [details] [diff] [review]
0001-Bug-1321642-Add-missing-include-guards-to-nsDeviceContextAndroid.h-16120113-1ac30dc.patch

Attached to wrong bug
Attachment #8816273 - Attachment is obsolete: true
(Assignee)

Comment 3

2 years ago
Created attachment 8816275 [details] [diff] [review]
0001-Bug-1321644-part-1-Remove-android-specific-message-loop-code-from-APZThreadUtils.cpp-16120113-a515cc6.patch
(Assignee)

Comment 4

2 years ago
Created attachment 8816276 [details] [diff] [review]
0002-Bug-1321644-part-2-Remove-AndroidBridge-PostTaskToUiThread-from-RemoteContentController.cpp-16120113-1474d0a.patch
(Assignee)

Updated

2 years ago
Attachment #8816275 - Flags: review?(botond)
(Assignee)

Updated

2 years ago
Attachment #8816276 - Flags: review?(botond)

Updated

2 years ago
Attachment #8816275 - Flags: review?(botond) → review+

Updated

2 years ago
Attachment #8816276 - Flags: review?(botond) → review+

Comment 5

2 years ago
Pushed by rbarker@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c25bce77b775
part 1, Remove android specific message loop code from APZThreadUtils.cpp r=botond
https://hg.mozilla.org/integration/mozilla-inbound/rev/60ba1893ecf3
part 2, Remove AndroidBridge::PostTaskToUiThread from RemoteContentController.cpp r=botond
I had to back this (and the other bug from your push) out for android xpcshell bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=40966554&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/f0840950a19b8d610f4974d8f2d908866bfa7493
Flags: needinfo?(rbarker)
(Assignee)

Updated

2 years ago
Flags: needinfo?(rbarker)

Comment 7

2 years ago
Pushed by rbarker@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/98d6700b6e2c
part 1, Remove android specific message loop code from APZThreadUtils.cpp r=botond
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb7b4a449847
part 2, Remove AndroidBridge::PostTaskToUiThread from RemoteContentController.cpp r=botond

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/98d6700b6e2c
https://hg.mozilla.org/mozilla-central/rev/fb7b4a449847
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53

Updated

2 years ago
Depends on: 1326091
You need to log in before you can comment on or make changes to this bug.