1321662 - Ensure that Carp and Carp::Heavy are only loaded after @INC is setup with the vendor bundles

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Dylan Hardison [:dylan] (he/him)]

IO::Async requires Future, which requires a newer version of Carp than we have installed in SCL3.

Carton is smart enough to realize this and bundle it.

However, if we load Carp before @INC contains the carton dir,
we'll be in a situation where Carp and Carp::Heavy disagree.


Many things directly load Carp:

1) FindBin
2) File::Basename

So this is a difficult problem to fix

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1321662_2.patch

Only FindBin is problematic

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1321662_3.patch

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 8817083 [details] [diff] [review]
1321662_3.patch

Review of attachment 8817083 [details] [diff] [review]:
-----------------------------------------------------------------

the qa/t/*.t scripts run from inside the qa/t dir so the files you have changed need to be:

use lib qw(lib ../../lib ../../local/lib/perl5);

Fix on commit. r=dkl

Comment 4

[Dylan Hardison [:dylan] (he/him)]

To [e-mail]:mozilla-bteam/bmo.git
   19caea8..72197b5  master -> master