1321801 - GYP build depends on a newer gyp

Status: RESOLVED WONTFIX

(NSS :: Build, defect)

Description

[(not currently active) Ted Mielczarek]

I noticed this a while ago but forgot to file it. Using the gyp that ships with Ubuntu 14.04 you get:
"gyp: target_conditions _type=="shared_library" must be length 2 or 3, not 6"

It's because of this conditional in config.gypi, which was added in bug 1311615:
https://hg.mozilla.org/projects/nss/file/5f2db99c258f/coreconf/config.gypi#l130

Support for those else-if style conditions in gyp was added in this changeset about 2 years ago:
https://chromium.googlesource.com/external/gyp/+/fb8a7bd650623317aedf642111a862810247a626

It's a slight annoyance to have to use a newer gyp, but gyp files are ugly enough that maybe requiring newer gyp to use this feature is worthwhile. I just wanted to point it out so we make an explicit decision on it.

Comment 1

[Franziskus Kiefer [:franziskus]]

I noticed this as well. But I don't think we should change our gyp files because of that. We'll have to support the old make file system for a while anyway. So old systems like Ubuntu 14.04 can use that for the time being.

Comment 2

[Martin Thomson [:mt:]]

This has been this way for a while now, and I think that 3 years is ample time to get acclimatized to using a newer version of software.